[swift-evolution] [swift-evolution-announce] SE-163: String Revision: Collection Conformance, C Interop, Transcoding

[Howard Lovatt]

review of "SE-163: String Revision: Collection Conformance, C Interop,
Transcoding"

 What is your evaluation of the proposal?
• Is the problem being addressed significant enough to warrant a change to
Swift?

Yes. It is much more consistent to think of a String as a Collection of
Characters and change to copying when taking a sub-string is welcome.

• Does this proposal fit well with the feel and direction of Swift?

Yes. It will make String code easier to follow.

• If you have used other languages or libraries with a similar feature, how
do you feel that this proposal compares to those?

Yes Java. Change to copying sub-strings worked well.

• How much effort did you put into your review? A glance, a quick reading,
or an in-depth study?

Read the proposal and familiar with similar issues in Java

  -- Howard.

On 6 April 2017 at 04:39, John McCall <rjmccall at apple.com> wrote:

> Hello, Swift community!
>
> The review of "SE-163: String Revision: Collection Conformance, C Interop,
> Transcoding" begins now and runs through next Tuesday, April 11th. The
> proposal is available here:
> https://github.com/apple/swift-evolution/blob/master/
> proposals/0163-string-revision-1.md
>
> Reviews are an important part of the Swift evolution process. All reviews
> should be sent to the swift-evolution mailing list at
> https://lists.swift.org/mailman/listinfo/swift-evolution
> or, if you would like to keep your feedback private, directly to the
> review manager. When replying, please try to keep the proposal link at the
> top of the message:
>
> Proposal link: https://github.com/apple/swift-evolution/blob/
> master/proposals/0155-normalize-enum-case-representation.md
>
> Reply text
>
> Other replies
>
> *What goes into a review?*
>
> The goal of the review process is to improve the proposal under review
> through constructive criticism and, eventually, determine the direction of
> Swift. When writing your review, here are some questions you might want to
> answer in your review:
>
> • What is your evaluation of the proposal?
> • Is the problem being addressed significant enough to warrant a change to
> Swift?
> • Does this proposal fit well with the feel and direction of Swift?
> • If you have used other languages or libraries with a similar feature,
> how do you feel that this proposal compares to those?
> • How much effort did you put into your review? A glance, a quick reading,
> or an in-depth study?
>
> More information about the Swift evolution process is available at
> https://github.com/apple/swift-evolution/blob/master/process.md
>
> Thank you,
>
> John McCall
> Review Manager
>
> _______________________________________________
> swift-evolution-announce mailing list
> swift-evolution-announce at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution-announce
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20170406/655e761f/attachment.html>