[swift-evolution] SE-163: String Revision: Collection Conformance, C Interop, Transcoding

[Xiaodi Wu]

On Wed, Apr 5, 2017 at 1:39 PM, John McCall via swift-evolution <
swift-evolution at swift.org> wrote:

> Hello, Swift community!
>
> The review of "SE-163: String Revision: Collection Conformance, C Interop,
> Transcoding" begins now and runs through next Tuesday, April 11th. The
> proposal is available here:
> https://github.com/apple/swift-evolution/blob/master/
> proposals/0163-string-revision-1.md
>
> Reviews are an important part of the Swift evolution process. All reviews
> should be sent to the swift-evolution mailing list at
> https://lists.swift.org/mailman/listinfo/swift-evolution
> or, if you would like to keep your feedback private, directly to the
> review manager. When replying, please try to keep the proposal link at the
> top of the message:
>
> Proposal link: https://github.com/apple/swift-evolution/blob/
> master/proposals/0155-normalize-enum-case-representation.md
>
> Reply text
>
> Other replies
>
> *What goes into a review?*
>
> The goal of the review process is to improve the proposal under review
> through constructive criticism and, eventually, determine the direction of
> Swift. When writing your review, here are some questions you might want to
> answer in your review:
>
> • What is your evaluation of the proposal?
>

+1. This is a good start for the String overhaul.


> • Is the problem being addressed significant enough to warrant a change to
> Swift?
>

Yes.


> • Does this proposal fit well with the feel and direction of Swift?
>

Yes.

I continue to want to nitpick the nouning of the verb "parse." I can agree
that it's not a "ParsedResult" because not all instances will have a
result. But it certainly is a "ParsingResult" and not a "ParseResult"
because parse really isn't a noun. That is all.

(Personally, I would be happy with either "StringProtocol" or "Unicode." If
the Collection-ness of the protocol is important, "UnicodeCollection" might
allay some people's fears that "Unicode" is a funny-sounding protocol name.)


> • If you have used other languages or libraries with a similar feature,
> how do you feel that this proposal compares to those?
>

I absolutely love that Swift is Unicode-correct by default. In this
respect, Swift is already ahead of other languages. The lack of Collection
conformance is a pain point, and this proposal addresses that head-on.


> • How much effort did you put into your review? A glance, a quick reading,
> or an in-depth study?
>

A moderate amount of effort; previously, a greater amount of effort.
Also, clearly more effort than the review manager, since the last link is
copypasta ;)

More information about the Swift evolution process is available at
> https://github.com/apple/swift-evolution/blob/master/process.md
>
> Thank you,
>
> John McCall
> Review Manager
>
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20170405/337c31fb/attachment.html>