<div dir="ltr"><span style="font-size:12.8px">review of "SE-163: String Revision: Collection Conformance, C Interop, Transcoding"</span><br><div><span style="font-size:12.8px"><br></span></div><div><div style="font-size:12.8px"> What is your evaluation of the proposal?<br></div><div style="font-size:12.8px"><span class="gmail-m_7808588454804018479Apple-tab-span" style="white-space:pre-wrap"> </span>• Is the problem being addressed significant enough to warrant a change to Swift?<br></div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">Yes. It is much more consistent to think of a String as a Collection of Characters and change to copying when taking a sub-string is welcome.</div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px"><span class="gmail-m_7808588454804018479Apple-tab-span" style="white-space:pre-wrap"> </span>• Does this proposal fit well with the feel and direction of Swift?<br></div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">Yes. It will make String code easier to follow.</div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px"><span class="gmail-m_7808588454804018479Apple-tab-span" style="white-space:pre-wrap"> </span>• If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br></div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">Yes Java. Change to copying sub-strings worked well.</div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px"><span class="gmail-m_7808588454804018479Apple-tab-span" style="white-space:pre-wrap"> </span>• How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</div></div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">Read the proposal and familiar with similar issues in Java</div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"> -- Howard.<br></div></div>
<br><div class="gmail_quote">On 6 April 2017 at 04:39, John McCall <span dir="ltr"><<a href="mailto:rjmccall@apple.com" target="_blank">rjmccall@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Hello, Swift community!<br><br>The review of "SE-163: String Revision: Collection Conformance, C Interop, Transcoding" begins now and runs through next Tuesday, April 11th. The proposal is available here:<div><span class="m_7808588454804018479Apple-tab-span" style="white-space:pre-wrap"> </span><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0163-string-revision-1.md" target="_blank">https://github.com/apple/<wbr>swift-evolution/blob/master/<wbr>proposals/0163-string-<wbr>revision-1.md</a></div><div><br></div><div><div>Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at</div><div><span class="m_7808588454804018479Apple-tab-span" style="white-space:pre-wrap"> </span><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-<wbr>evolution</a></div><div>or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:</div><div><br><span class="m_7808588454804018479Apple-tab-span" style="white-space:pre-wrap"> </span>Proposal link: <a href="https://github.com/apple/swift-evolution/blob/master/proposals/0155-normalize-enum-case-representation.md" target="_blank">https://github.com/<wbr>apple/swift-evolution/blob/<wbr>master/proposals/0155-<wbr>normalize-enum-case-<wbr>representation.md</a></div><div><br></div><div><span class="m_7808588454804018479Apple-tab-span" style="white-space:pre-wrap"> </span>Reply text</div><div><br><span class="m_7808588454804018479Apple-tab-span" style="white-space:pre-wrap"> </span>Other replies</div><div><br></div><div><b>What goes into a review?</b><br><br>The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:<br><br><div><span class="m_7808588454804018479Apple-tab-span" style="white-space:pre-wrap"> </span>• What is your evaluation of the proposal?<br></div><div><span class="m_7808588454804018479Apple-tab-span" style="white-space:pre-wrap"> </span>• Is the problem being addressed significant enough to warrant a change to Swift?<br></div><div><span class="m_7808588454804018479Apple-tab-span" style="white-space:pre-wrap"> </span>• Does this proposal fit well with the feel and direction of Swift?<br></div><div><span class="m_7808588454804018479Apple-tab-span" style="white-space:pre-wrap"> </span>• If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br></div><div><span class="m_7808588454804018479Apple-tab-span" style="white-space:pre-wrap"> </span>• How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br></div><div><br></div>More information about the Swift evolution process is available at <a href="https://github.com/apple/swift-evolution/blob/master/process.md" target="_blank">https://github.com/apple/<wbr>swift-evolution/blob/master/<wbr>process.md</a><div><br><div>Thank you,<br><br>John McCall<br>Review Manager</div></div></div></div></div><br>______________________________<wbr>_________________<br>
swift-evolution-announce mailing list<br>
<a href="mailto:swift-evolution-announce@swift.org">swift-evolution-announce@<wbr>swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution-announce" rel="noreferrer" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-<wbr>evolution-announce</a><br>
<br></blockquote></div><br></div>