<div dir="ltr">On Wed, Apr 5, 2017 at 1:39 PM, John McCall via swift-evolution <span dir="ltr"><<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Hello, Swift community!<br><br>The review of "SE-163: String Revision: Collection Conformance, C Interop, Transcoding" begins now and runs through next Tuesday, April 11th. The proposal is available here:<div><span class="m_4407530605742802631Apple-tab-span" style="white-space:pre-wrap"> </span><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0163-string-revision-1.md" target="_blank">https://github.com/apple/<wbr>swift-evolution/blob/master/<wbr>proposals/0163-string-<wbr>revision-1.md</a></div><div><br></div><div><div>Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at</div><div><span class="m_4407530605742802631Apple-tab-span" style="white-space:pre-wrap"> </span><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-<wbr>evolution</a></div><div>or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:</div><div><br><span class="m_4407530605742802631Apple-tab-span" style="white-space:pre-wrap"> </span>Proposal link: <a href="https://github.com/apple/swift-evolution/blob/master/proposals/0155-normalize-enum-case-representation.md" target="_blank">https://github.com/<wbr>apple/swift-evolution/blob/<wbr>master/proposals/0155-<wbr>normalize-enum-case-<wbr>representation.md</a></div><div><br></div><div><span class="m_4407530605742802631Apple-tab-span" style="white-space:pre-wrap"> </span>Reply text</div><div><br><span class="m_4407530605742802631Apple-tab-span" style="white-space:pre-wrap"> </span>Other replies</div><div><br></div><div><b>What goes into a review?</b><br><br>The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:<br><br><div><span class="m_4407530605742802631Apple-tab-span" style="white-space:pre-wrap"> </span>• What is your evaluation of the proposal?<br></div></div></div></div></blockquote><div><br></div><div>+1. This is a good start for the String overhaul.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><div></div><div><span class="m_4407530605742802631Apple-tab-span" style="white-space:pre-wrap"> </span>• Is the problem being addressed significant enough to warrant a change to Swift?<br></div></div></div></div></blockquote><div><br></div><div>Yes.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><div></div><div><span class="m_4407530605742802631Apple-tab-span" style="white-space:pre-wrap"> </span>• Does this proposal fit well with the feel and direction of Swift?<br></div></div></div></div></blockquote><div><br></div><div>Yes.</div><div><br></div><div>I continue to want to nitpick the nouning of the verb "parse." I can agree that it's not a "ParsedResult" because not all instances will have a result. But it certainly is a "ParsingResult" and not a "ParseResult" because parse really isn't a noun. That is all.</div><div><br></div><div>(Personally, I would be happy with either "StringProtocol" or "Unicode." If the Collection-ness of the protocol is important, "UnicodeCollection" might allay some people's fears that "Unicode" is a funny-sounding protocol name.)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><div></div><div><span class="m_4407530605742802631Apple-tab-span" style="white-space:pre-wrap"> </span>• If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br></div></div></div></div></blockquote><div><br></div><div>I absolutely love that Swift is Unicode-correct by default. In this respect, Swift is already ahead of other languages. The lack of Collection conformance is a pain point, and this proposal addresses that head-on.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><div></div><div><span class="m_4407530605742802631Apple-tab-span" style="white-space:pre-wrap"> </span>• How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br></div></div></div></div></blockquote><div><br></div><div>A moderate amount of effort; previously, a greater amount of effort.</div><div>Also, clearly more effort than the review manager, since the last link is copypasta ;)</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div>More information about the Swift evolution process is available at <a href="https://github.com/apple/swift-evolution/blob/master/process.md" target="_blank">https://github.com/apple/<wbr>swift-evolution/blob/master/<wbr>process.md</a><div><br><div>Thank you,<br><br>John McCall<br>Review Manager</div></div></div></div></div><br>______________________________<wbr>_________________<br>
swift-evolution mailing list<br>
<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-<wbr>evolution</a><br>
<br></blockquote></div><br></div></div>