[swift-evolution] [Review] SE-0088: Modernize libdispatch for Swift 3 naming conventions

Austin Zheng austinzheng at gmail.com
Wed May 11 00:22:16 CDT 2016

I think this is a great idea and a great proposal. GCD is already a
powerful, elegant tool available to Swift users, and this makes it feel
even more Swift-like.

- Is there a use case for user subclassing of a queue type? If not, should
they be final?
- Is there a reason to use class methods rather than static methods for the
queue types? I was under the impression that static methods would be
preferred unless a good reason exists to dispatch upon metatype.
- Nit: "DispatchWallTime" is spelled "DispatchWalltime" (lowercase 't') in
the code samples.
- Is it allowed/technically possible for non-stdlib code to use


On Tue, May 10, 2016 at 9:39 PM, Chris Lattner via swift-evolution <
swift-evolution at swift.org> wrote:

> Hello Swift community,
> The review of "SE-0088: Modernize libdispatch for Swift 3 naming
> conventions" begins now and runs through May 17. The proposal is available
> here:
> https://github.com/apple/swift-evolution/blob/master/proposals/0088-libdispatch-for-swift3.md
> Reviews are an important part of the Swift evolution process. All reviews
> should be sent to the swift-evolution mailing list at
>         https://lists.swift.org/mailman/listinfo/swift-evolution
> or, if you would like to keep your feedback private, directly to the
> review manager.
> What goes into a review?
> The goal of the review process is to improve the proposal under review
> through constructive criticism and contribute to the direction of Swift.
> When writing your review, here are some questions you might want to answer
> in your review:
>         * What is your evaluation of the proposal?
>         * Is the problem being addressed significant enough to warrant a
> change to Swift?
>         * Does this proposal fit well with the feel and direction of Swift?
>         * If you have used other languages or libraries with a similar
> feature, how do you feel that this proposal compares to those?
>         * How much effort did you put into your review? A glance, a quick
> reading, or an in-depth study?
> More information about the Swift evolution process is available at
>         https://github.com/apple/swift-evolution/blob/master/process.md
> Thank you,
> -Chris Lattner
> Review Manager
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20160510/aeebbc13/attachment.html>

More information about the swift-evolution mailing list