[swift-dev] ArchetypeBuilder rename

Slava Pestov spestov at apple.com
Tue Feb 7 21:13:19 CST 2017

Do you mind if I merge https://github.com/apple/swift/pull/7319 <https://github.com/apple/swift/pull/7319> first? It’s ready to go in.


> On Feb 7, 2017, at 4:59 PM, Douglas Gregor via swift-dev <swift-dev at swift.org> wrote:
> Hi all,
> The ArchetypeBuilder <https://github.com/apple/swift/blob/master/include/swift/AST/ArchetypeBuilder.h> class, whose primary responsibility is to validate, minimize, and canonicalize generic signatures, now has almost nothing to do with archetypes. I’d like to rename it to GenericSignatureBuilder. Two questions:
> 1) Does anyone have an issue with this new name?
> 2) Other than https://github.com/apple/swift/pull/7313 <https://github.com/apple/swift/pull/7313> and https://github.com/apple/swift/pull/7319 <https://github.com/apple/swift/pull/7319>, does anyone have significant outstanding changes to the ArchetypeBuilder for which rebasing after a rename would be awful? If so, I can hold off on the rename for a bit longer.
> 	- Doug
> _______________________________________________
> swift-dev mailing list
> swift-dev at swift.org
> https://lists.swift.org/mailman/listinfo/swift-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-dev/attachments/20170207/ea117836/attachment.html>

More information about the swift-dev mailing list