[swift-dev] ArchetypeBuilder rename
dgregor at apple.com
Tue Feb 7 21:46:25 CST 2017
Go for it! I haven't even created the renaming PR and don't want to step on toes.
Sent from my iPhone
> On Feb 7, 2017, at 7:13 PM, Slava Pestov <spestov at apple.com> wrote:
> Do you mind if I merge https://github.com/apple/swift/pull/7319 first? It’s ready to go in.
>> On Feb 7, 2017, at 4:59 PM, Douglas Gregor via swift-dev <swift-dev at swift.org> wrote:
>> Hi all,
>> The ArchetypeBuilder class, whose primary responsibility is to validate, minimize, and canonicalize generic signatures, now has almost nothing to do with archetypes. I’d like to rename it to GenericSignatureBuilder. Two questions:
>> 1) Does anyone have an issue with this new name?
>> 2) Other than https://github.com/apple/swift/pull/7313 and https://github.com/apple/swift/pull/7319, does anyone have significant outstanding changes to the ArchetypeBuilder for which rebasing after a rename would be awful? If so, I can hold off on the rename for a bit longer.
>> - Doug
>> swift-dev mailing list
>> swift-dev at swift.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the swift-dev