[swift-evolution] [Review] SE-0176: Remove ownership keyword support in protocols

[Tony Allevato]

On Wed, Sep 20, 2017 at 1:11 PM Ted Kremenek via swift-evolution <
swift-evolution at swift.org> wrote:

> The review of “SE-0186: Remove ownership keyword support in protocols”
> begins now and runs through September 27.
>
> The proposal is available here:
>
>
> https://github.com/apple/swift-evolution/blob/master/proposals/0186-remove-ownership-keyword-support-in-protocols.md
>
> Reviews are an important part of the Swift evolution process. All review
> feedback should be sent to the swift-evolution mailing list at:
>
>    https://lists.swift.org/mailman/listinfo/swift-evolution
>
> or, if you would like to keep your feedback private, directly to the
> review manager.
>
> When replying, please try to keep the proposal link at the top of the
> message:
>
>  Proposal link:
> https://github.com/apple/swift-evolution/blob/master/proposals/0186-remove-ownership-keyword-support-in-protocols.md
>  ….
>  Reply text
>  ...
>  Other replies
>
>
> *## What goes into a review of a proposal?*
>
> The goal of the review process is to improve the proposal under review
> through constructive criticism and, eventually, determine the direction of
> Swift.
>
> When reviewing a proposal, here are some questions to consider:
>
> * What is your evaluation of the proposal?
>

+1. Seems pretty straightforward and non-controversial. If the keywords are
not valid, they shouldn't be allowed.

While it's tempting to ask "could these keywords be given their proper
meaning instead of removing them?" the proposal addresses that by pointing
out that it's a much deeper design decision that would require more debate,
and regardless of the outcome of that, misleading keywords shouldn't be
allowed in the interim. Let's fix the immediate bug now and consider the
rest later.


> * Is the problem being addressed significant enough to warrant a change to
> Swift?
>

Yes, it prevents people from writing code that doesn't guarantee what they
think it does.


>
> * Does this proposal fit well with the feel and direction of Swift?
>

> * If you have used other languages or libraries with a similar feature,
> how do you feel that this proposal compares to those?
>
> * How much effort did you put into your review? A glance, a quick reading,
> or an in-depth study?
>

Read the proposal just now.


>
>
> Thanks,
> Ted Kremenek
> Review Manager
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20170920/6916f069/attachment.html>