[swift-evolution] [swift-evolution-announce] [Review] SE-0176: Remove ownership keyword support in protocols

[Howard Lovatt]

> review of “SE-0186: Remove ownership keyword support in protocols”

> * What is your evaluation of the proposal?

+1, sensible to remove misleading definitions
> 
> * Is the problem being addressed significant enough to warrant a change to Swift?

Yes, could easily lead to bugs. 
> 
> * Does this proposal fit well with the feel and direction of Swift?

Yes, cleaning up Swift is part of the evolution 
> 
> * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?

No
> 
> * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

Quick read. 

-- Howard. 

> On 21 Sep 2017, at 6:11 am, Ted Kremenek <kremenek at apple.com> wrote:
> 
> The review of “SE-0186: Remove ownership keyword support in protocols” begins now and runs through September 27.
> 
> The proposal is available here:
> 
>    https://github.com/apple/swift-evolution/blob/master/proposals/0186-remove-ownership-keyword-support-in-protocols.md
> 
> Reviews are an important part of the Swift evolution process. All review feedback should be sent to the swift-evolution mailing list at:
> 
>    https://lists.swift.org/mailman/listinfo/swift-evolution 
> 
> or, if you would like to keep your feedback private, directly to the review manager. 
> 
> When replying, please try to keep the proposal link at the top of the message:
> 
>>  Proposal link:  https://github.com/apple/swift-evolution/blob/master/proposals/0186-remove-ownership-keyword-support-in-protocols.md
>>  ….
>>  Reply text
>>  ...
>>  Other replies
> 
> 
> ## What goes into a review of a proposal?
> 
> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. 
> 
> When reviewing a proposal, here are some questions to consider:
> 
> * What is your evaluation of the proposal?
> 
> * Is the problem being addressed significant enough to warrant a change to Swift?
> 
> * Does this proposal fit well with the feel and direction of Swift?
> 
> * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
> 
> * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
> 
> 
> Thanks,
> Ted Kremenek
> Review Manager
> _______________________________________________
> swift-evolution-announce mailing list
> swift-evolution-announce at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution-announce
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20170921/38ba9514/attachment.html>