[swift-evolution] [Review] SE-0173: Add `MutableCollection.swap(_:with:)

[Saagar Jha]

+1 overall; the proposal is well justified and I don’t see any reason why it should be rejected.

One nitpick I do have is with the choice of the argument parameter: elements.swap(i, with: j) seems at first glance (to me, at least) to swap the elements i and j, not the element at i with the element at j. The original (free) function made sense because it actually performed its operation on the elements, but here I’d prefer it if we used elements.swap(at: i, j) to make it explicit that that arguments are on indices and not elements.

Saagar Jha

P.S. The link to the manifesto has a typo (“manfiesto”).

> On Apr 25, 2017, at 11:32, Ted Kremenek via swift-evolution <swift-evolution at swift.org> wrote:
> 
> Hello Swift community,
> 
> The review of SE-0173 "Add MutableCollection.swap(_:with:)" begins now and runs through April 28, 2017.
> 
> The proposal is available here:
> 
> https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md <https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md>
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at:
> 
> https://lists.swift.org/mailman/listinfo/swift-evolution <https://lists.swift.org/mailman/listinfo/swift-evolution>
> or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:
> 
> Proposal link:
> 
> https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md <https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md>
> Reply text
> 
> Other replies
> What goes into a review?
> 
> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> 
> What is your evaluation of the proposal?
> Is the problem being addressed significant enough to warrant a change to Swift?
> Does this proposal fit well with the feel and direction of Swift?
> If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
> How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
> More information about the Swift evolution process is available at:
> 
> https://github.com/apple/swift-evolution/blob/master/process.md <https://github.com/apple/swift-evolution/blob/master/process.md>
> Thank you,
> Ted (Review Manager)
> 
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20170425/3668182f/attachment.html>