<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">+1 overall; the proposal is well justified and I don’t see any reason why it should be rejected.<div class=""><br class=""></div><div class="">One nitpick I do have is with the choice of the argument parameter: elements.swap(i, with: j) seems at first glance (to me, at least) to swap the <i class="">elements i and j</i>, not the element at i with the element at j. The original (free) function made sense because it actually performed its operation on the elements, but here I’d prefer it if we used elements.swap(at: i, j) to make it explicit that that arguments are on indices and not elements.<div class=""><br class=""><div class="">
<div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Saagar Jha</div>
</div><div class=""><br class="webkit-block-placeholder"></div><div class="">P.S. The link to the manifesto has a typo (“manfiesto”).</div>
<br class=""><div><blockquote type="cite" class=""><div class="">On Apr 25, 2017, at 11:32, Ted Kremenek via swift-evolution <<a href="mailto:swift-evolution@swift.org" class="">swift-evolution@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><p style="-webkit-print-color-adjust: exact; margin-right: 0px; margin-bottom: 15px; margin-left: 0px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255); margin-top: 0px !important;" class="">Hello Swift community,</p><p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class="">The review of SE-0173 "Add MutableCollection.swap(_:with:)" begins now and runs through <strong style="-webkit-print-color-adjust: exact;" class="">April 28, 2017</strong>.</p><p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class="">The proposal is available here:</p><p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class=""><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md" style="-webkit-print-color-adjust: exact; color: rgb(65, 131, 196);" class="">https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md</a></p><p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class="">Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at:</p><p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class=""><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" class="">https://lists.swift.org/mailman/listinfo/swift-evolution</a></p><p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class="">or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:</p><blockquote style="-webkit-print-color-adjust: exact; margin: 15px 0px; border-left-width: 4px; border-left-style: solid; border-left-color: rgb(221, 221, 221); padding: 0px 15px; color: rgb(119, 119, 119); font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class=""><h3 id="toc_0" style="-webkit-print-color-adjust: exact; margin: 0px 0px 10px; padding: 0px; -webkit-font-smoothing: antialiased; cursor: text; position: relative; font-size: 18px;" class="">Proposal link:</h3><blockquote style="-webkit-print-color-adjust: exact; margin: 15px 0px 0px; border-left-width: 4px; border-left-style: solid; border-left-color: rgb(221, 221, 221); padding: 0px 15px;" class=""><p style="-webkit-print-color-adjust: exact; margin: 0px 0px 15px;" class=""><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md" class="">https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md</a></p><h3 id="toc_1" style="-webkit-print-color-adjust: exact; margin: 20px 0px 10px; padding: 0px; -webkit-font-smoothing: antialiased; cursor: text; position: relative; font-size: 18px;" class="">Reply text</h3><p style="-webkit-print-color-adjust: exact; margin: 15px 0px 0px;" class="">Other replies</p></blockquote></blockquote><h3 id="toc_2" style="-webkit-print-color-adjust: exact; margin: 20px 0px 10px; padding: 0px; -webkit-font-smoothing: antialiased; cursor: text; position: relative; font-size: 18px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class="">What goes into a review?</h3><p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class="">The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:</p><ul style="-webkit-print-color-adjust: exact; margin: 15px 0px; padding-left: 30px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class=""><li style="-webkit-print-color-adjust: exact; margin: 0px;" class="">What is your evaluation of the proposal?</li><li style="-webkit-print-color-adjust: exact; margin: 0px;" class="">Is the problem being addressed significant enough to warrant a change to Swift?</li><li style="-webkit-print-color-adjust: exact; margin: 0px;" class="">Does this proposal fit well with the feel and direction of Swift?</li><li style="-webkit-print-color-adjust: exact; margin: 0px;" class="">If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?</li><li style="-webkit-print-color-adjust: exact; margin: 0px;" class="">How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</li></ul><p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class="">More information about the Swift evolution process is available at:</p><p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class=""><a href="https://github.com/apple/swift-evolution/blob/master/process.md" style="-webkit-print-color-adjust: exact; color: rgb(65, 131, 196);" class="">https://github.com/apple/swift-evolution/blob/master/process.md</a></p><p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class="">Thank you,<br style="-webkit-print-color-adjust: exact;" class="">Ted (Review Manager)</p></div>_______________________________________________<br class="">swift-evolution mailing list<br class=""><a href="mailto:swift-evolution@swift.org" class="">swift-evolution@swift.org</a><br class="">https://lists.swift.org/mailman/listinfo/swift-evolution<br class=""></div></blockquote></div><br class=""></div></div></body></html>