[swift-evolution] SE-165: Dictionary & Set Enhancements

[Xiaodi Wu]

This is an excellent proposal and a worthy addition. The problems addressed
are significant and these changes in general fit well with the direction of
Swift. One nit below, but otherwise I think this will be pretty great.

Nit:

merge(_:mergingValues:) and friends should be more consistent with other
closure labels as revised in SE-0118. Some options:

merge(_:mergingValuesBy:) // the "by" is used consistently in similar
closure labels
merge(_:combiningValuesBy:) // avoids repeating the word "merge"
merge(_:makingValueWith:) // by analogy with
ManagedBuffer.create(minimumCapacity:makingValueWith:)
merge(_:by:) // as with earlier versions of SE-0118, worth considering if
the more verbose labels "do much to enhance readability at the point of use"

On Wed, Apr 5, 2017 at 19:45 Ben Cohen via swift-evolution <
swift-evolution at swift.org> wrote:

> Hello, Swift community!
>
> The review of "SE-165: Dictionary & Set Enhancements" begins now and runs
> through next Tuesday, April 11th. The proposal is available here:
> https://github.com/apple/swift-evolution/blob/master/proposals/0165-dict.md
>
> Reviews are an important part of the Swift evolution process. All reviews
> should be sent to the swift-evolution mailing list at
> https://lists.swift.org/mailman/listinfo/swift-evolution
>
> or, if you would like to keep your feedback private, directly to the
> review manager. When replying, please try to keep the proposal link at the
> top of the message:
>
> Proposal link:
> https://github.com/apple/swift-evolution/blob/master/proposals/0165-dict.md
>
> Reply text
>
> Other replies
>
> *What goes into a review?*
>
> The goal of the review process is to improve the proposal under review
> through constructive criticism and, eventually, determine the direction of
> Swift. When writing your review, here are some questions you might want to
> answer in your review:
>
> • What is your evaluation of the proposal?
> • Is the problem being addressed significant enough to warrant a change to
> Swift?
> • Does this proposal fit well with the feel and direction of Swift?
> • If you have used other languages or libraries with a similar feature,
> how do you feel that this proposal compares to those?
> • How much effort did you put into your review? A glance, a quick reading,
> or an in-depth study?
>
> More information about the Swift evolution process is available at
> https://github.com/apple/swift-evolution/blob/master/process.md
>
> Thank you,
>
> Ben Cohen
> Review Manager
>
>
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20170406/f1df1eee/attachment.html>