[swift-evolution] [Review] SE-0159: Fix Private Access Levels

[David Beck]

   - What is your evaluation of the proposal?

Definitely in favor of this. About halfway through the Swift 3 migration I
gave up trying to think through where to use fileprivate and where to use
private and just did a project level find and replace to use fileprivate
everywhere. So far over the last year I haven't found a case where I want
to use private instead of fileprivate. The one time I thought it came up,
when I looked at it again I realized I really should be using 2 files
anyway.


   - Is the problem being addressed significant enough to warrant a change
   to Swift?

Maybe. It certainly would remove confusion.


   - Does this proposal fit well with the feel and direction of Swift?

Yes.


   - If you have used other languages or libraries with a similar feature,
   how do you feel that this proposal compares to those?

I don't think I've ever seen a language distinguish private and
fileprivate. It seems like all other languages choose one behavior or the
other, and stick with it. Adding fileprivate seemed like Swift's attempt to
make everyone happy, when it wasn't needed.


   - How much effort did you put into your review? A glance, a quick
   reading, or an in-depth study?

Read through the proposal.

On Mon, Mar 20, 2017 at 4:54 PM, Douglas Gregor via swift-evolution <
swift-evolution at swift.org> wrote:

> Hello Swift community,
>
> The review of SE-0159 "Fix Private Access Levels" begins now and runs
> through March 27, 2017. The proposal is available here:
>
> https://github.com/apple/swift-evolution/blob/master/
> proposals/0159-fix-private-access-levels.md
>
> Reviews are an important part of the Swift evolution process. All reviews
> should be sent to the swift-evolution mailing list at
>
> https://lists.swift.org/mailman/listinfo/swift-evolution
>
> or, if you would like to keep your feedback private, directly to the
> review manager. When replying, please try to keep the proposal link at the
> top of the message:
>
> Proposal link:
>
> https://github.com/apple/swift-evolution/blob/master/
> proposals/0159-fix-private-access-levels.md
>
> Reply text
>
> Other replies
>
>
> <https://github.com/apple/swift-evolution/blob/master/process.md#what-goes-into-a-review-1>What
> goes into a review?
>
> The goal of the review process is to improve the proposal under review
> through constructive criticism and, eventually, determine the direction of
> Swift. When writing your review, here are some questions you might want to
> answer in your review:
>
>    - What is your evaluation of the proposal?
>    - Is the problem being addressed significant enough to warrant a
>    change to Swift?
>    - Does this proposal fit well with the feel and direction of Swift?
>    - If you have used other languages or libraries with a similar
>    feature, how do you feel that this proposal compares to those?
>    - How much effort did you put into your review? A glance, a quick
>    reading, or an in-depth study?
>
> More information about the Swift evolution process is available at
>
> https://github.com/apple/swift-evolution/blob/master/process.md
>
> Thank you,
>
> -Doug
>
> Review Manager
>
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20170322/a298b578/attachment.html>