[swift-evolution] [Review] SE-0159: Fix Private Access Levels

[Jarod Long]

>
> • What is your evaluation of the proposal?
>
I think it could stand to make a bit of a stronger case, but I am strongly in favor of the outcome. The introduction of fileprivate was disappointing to me when it happened, and I've yet to encounter a situation where it has been beneficial, but it has often been frustrating.

>
> • Is the problem being addressed significant enough to warrant a change to Swift?
>
I think so -- I believe that it's very important for this sort of fundamental language feature to be simple and pleasant to use. The tradeoffs that fileprivate makes in that regard feel pretty significant to me, and I don't think the additional level of control is of much benefit.

I would go as far as to say that scoped access control is harmful in that it promotes bad programming practices. If your file is large enough that there is value in protecting yourself from accessing certain parts of it, that file is almost certainly excessively large and difficult to follow.

>
> • Does this proposal fit well with the feel and direction of Swift?
>
I believe that it does to the extent that Swift strives to avoid overburdening its users with low-value features.

>
> • If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
>
I used Swift prior to version 3, and I strongly preferred the previous access control model.

>
> • How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
>
I read the proposal fully and have been casually following much of the discussion on this topic.

Jarod


On Mar 20, 2017, 16:54 -0700, Douglas Gregor via swift-evolution , wrote:
> Hello Swift community,
> The review of SE-0159 "Fix Private Access Levels" begins now and runs through March 27, 2017. The proposal is available here:
> > https://github.com/apple/swift-evolution/blob/master/proposals/0159-fix-private-access-levels.md
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at
> > https://lists.swift.org/mailman/listinfo/swift-evolution
> or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:
> > Proposal link:
> > > https://github.com/apple/swift-evolution/blob/master/proposals/0159-fix-private-access-levels.md
> > Reply text
> > > Other replies
> What goes into a review?
> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
>
> • What is your evaluation of the proposal?
> • Is the problem being addressed significant enough to warrant a change to Swift?
> • Does this proposal fit well with the feel and direction of Swift?
> • If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
> • How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
>
> More information about the Swift evolution process is available at
> > https://github.com/apple/swift-evolution/blob/master/process.md
> Thank you,
> -Doug
> Review Manager
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20170320/9ae28cad/attachment.html>