[swift-evolution] Some clarity lost from the great renaming
Brandon Knope
bknope at me.com
Wed Oct 19 10:13:24 CDT 2016
Sorry! I was unsure if this would be a breaking change so thought I would seek feedback.
It sounds like I'm not the only one bothered by this so I will file a radar
Brandon
Sent from my iPad
> On Oct 18, 2016, at 9:43 PM, Dave Abrahams via swift-evolution <swift-evolution at swift.org> wrote:
>
>
>> on Tue Oct 18 2016, Brandon Knope <swift-evolution at swift.org> wrote:
>>
>> I meant to bring this up a bit ago but just came across it again.
>>
>> I find this to not read properly:
>>
>> button.setTitle("Test", for: .normal) //for normal what?
>>
>> The for argument is really only clear in meaning when you are typing
>> it out and see that it is a UIControlState type. While reading it
>> without this context is it as clear? .normal doesn't seem descriptive
>> enough on its own.
>>
>> Contrast this with UISegmentedControl:
>> segmented.dividerImage(forLeftSegmentState: .normal, rightSegmentState: .normal, barMetrics:
>> .default)
>>
>> Here the parameter labels are needed because there needs to be a
>> distinction in the method between left and right. But here it is not
>> forLeft: or forRight: it is the much more clear forLeftSegmentState:
>>
>> So my question is: why was this not setTitle(forControlState:) or forButtonState, etc...?
>
> This is really not an evolution question at this point. I suggest
> filing radars against UIKit for things whose names could be improved.
>
> --
> -Dave
>
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution
More information about the swift-evolution
mailing list