[swift-evolution] [SHORT Review] SE-0133: Rename `flatten()` to `joined()`

Jose Cheyo Jimenez cheyo at masters3d.com
Mon Jul 25 09:31:27 CDT 2016

> On Jul 24, 2016, at 11:10 PM, Chris Lattner via swift-evolution <swift-evolution at swift.org> wrote:
> Hello Swift community,
> The review of "SE-0133: Rename `flatten()` to `joined()`" begins now and runs through July 26.  Apologies for the short review cycle, but we’re right up against the end of source breaking changes for Swift 3.  The proposal is available here:
>    https://github.com/apple/swift-evolution/blob/master/proposals/0133-rename-flatten-to-joined.md
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at
>    https://lists.swift.org/mailman/listinfo/swift-evolution
> or, if you would like to keep your feedback private, directly to the review manager.
> What goes into a review?
> The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
>    * What is your evaluation of the proposal?
>    * Is the problem being addressed significant enough to warrant a change to Swift?

I don't thinks so. 

>    * Does this proposal fit well with the feel and direction of Swift?

I think we would loose readability. I appreciate having flatten() specially when I have to combine it with joined().

This to me would be unfortunate when reading:
[["hey"], ["what"]].joined().joined()

>    * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
>    * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

Participated in thread. 
> More information about the Swift evolution process is available at
>    https://github.com/apple/swift-evolution/blob/master/process.md
> Thank you,
> -Chris Lattner
> Review Manager
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution

More information about the swift-evolution mailing list