[swift-evolution] [Review] SE-0122: Use colons for subscript declarations

[Leonardo Pessoa]

On 20 July 2016 at 02:50, Chris Lattner via swift-evolution
<swift-evolution at swift.org> wrote:
> Hello Swift community,
>
> The review of "SE-0122: Use colons for subscript declarations " begins now and runs through July 24. The proposal is available here:
>
>         https://github.com/apple/swift-evolution/blob/master/proposals/0122-use-colons-for-subscript-type-declarations.md
>
>         * What is your evaluation of the proposal?

I feel a little reluctant to approve this but I'll have to give my +1
just for the sake of consistency. Computed properties already use
colons despite being internally just functions just like subscripts
and the syntax is almost the same. I agree there may be an issue with
readability but so do with computed properties and I didn't see anyone
complaining about that syntax.

>         * Is the problem being addressed significant enough to warrant a change to Swift?

Despite accepting the change, I still don't think it is significant
enough. It is merely a cosmetic change that adds/enhances nothing to
the language.

>         * Does this proposal fit well with the feel and direction of Swift?

I'm not sure but it grants a bit more of consistency in its syntax.

>         * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?

Other languages I worked with make no distinction on how you declare
the type of variables, function returns and properties. I'm not saying
"drop the arrows" thou.

>         * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

Read the proposal and followed the thread discussing it.