[swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

[Xiaodi Wu]

>
>         * What is your evaluation of the proposal?
>

-1. I think the proposal has great technical merit; if implemented, it
would improve the developer experience and pave the way for other
improvements in expressivity in the future. However, the proposal doesn't
do what it says on the tin (aka in the title), and it fails to explain the
motivation behind it or the rationale for the specific solution proposed.
My first reaction on reading it was exactly the same as that of Jose Cheyo
Jimenez, because it seemed not to do what it advertised at all. Since input
from the community is important, a proposal that doesn't explain the
problem or solution adequately can't be subjected to the scrutiny it needs
before implementation, and unfortunately I'll have to give it a thumbs-down.

        * Is the problem being addressed significant enough to warrant a
> change to Swift?
>

There is a problem to be addressed, and I think that problem is
significant. However, it's not really explained in the proposal.


>         * Does this proposal fit well with the feel and direction of Swift?
>

Potentially.


>         * If you have used other languages or libraries with a similar
> feature, how do you feel that this proposal compares to those?
>

I have not.


>         * How much effort did you put into your review? A glance, a quick
> reading, or an in-depth study?
>

I thought about this in-depth and participated in the original discussion
about revisions to SE-0025 that revised how access levels are treated for
classes, structs, and enums.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20160713/6944f340/attachment.html>