[swift-evolution] [Review] SE-0118: Closure Parameter Names and Labels

Karl razielim at gmail.com
Thu Jul 7 11:22:32 CDT 2016

> The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> 	* What is your evaluation of the proposal?

+1. Cleans things up a bit. I particularly like that the new names tend to be shorter.

> 	* Is the problem being addressed significant enough to warrant a change to Swift?

Sure, it doesn’t hurt and it tidies things up quite nicely.

> 	* Does this proposal fit well with the feel and direction of Swift?

Very much so. It removes verbosity but doesn’t lose clarity.

> 	* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?

Doesn’t really apply. We’re talking about Swift; this feels closer to what Swift’s own standard library should look like.

> 	* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

Read the review, participated in the initial review on GitHub and earlier discussions so I was already familiar with it.

More information about the swift-evolution mailing list