[swift-evolution] [swift-evolution-announce] [Review] SE-0084: Allow trailing commas in parameter lists and tuples

[Jean-Daniel Dupas]

I really don’t like that proposal too.

While I can understand why it may be useful for list, I find it very confusing to allow it in function declaration. 
The motivation do not apply here. You can’t simply remove a parameter or reorder that without breaking all code that use that function (even function with default parameter as the parameter may be explicitly defined at invocation site).

Even in other places (list, enum, …), I think the kind of refactoring describe in the motivation is not something that is common enough to introduce that kind of syntax change.

And the fact that no alternative was investigated (like allowing new line as separator) make me think this proposal is not complete and shouldn’t be accepted as is anyway.

Jean-Daniel

> Le 14 mai 2016 à 21:25, Kenny Leung via swift-evolution <swift-evolution at swift.org> a écrit :
> 
> I am against this proposal.
> 
> - I think it makes the code look ugly and incomplete when there is a trailing comma
> - I much prefer the counter-proposal which would allow newline to be the separator for items in a list.
>    - in general, it’s much better when you can remove something from your code rather than add something to it
>    - this proposal serves the same purpose as allowing the trailing comma
> 
> -Kenny
> 
> 
>> On May 10, 2016, at 11:53 AM, Chris Lattner <clattner at apple.com> wrote:
>> 
>> Hello Swift community,
>> 
>> The review of "SE-0084: Allow trailing commas in parameter lists and tuples" begins now and runs through May 16. The proposal is available here:
>> 
>> 	https://github.com/apple/swift-evolution/blob/master/proposals/0084-trailing-commas.md
>> 
>> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at
>> 
>> 	https://lists.swift.org/mailman/listinfo/swift-evolution
>> 
>> or, if you would like to keep your feedback private, directly to the review manager.
>> 
>> What goes into a review?
>> 
>> The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
>> 
>> 	* What is your evaluation of the proposal?
>> 	* Is the problem being addressed significant enough to warrant a change to Swift?
>> 	* Does this proposal fit well with the feel and direction of Swift?
>> 	* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
>> 	* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
>> 
>> More information about the Swift evolution process is available at
>> 
>> 	https://github.com/apple/swift-evolution/blob/master/process.md
>> 
>> Thank you,
>> 
>> -Chris Lattner
>> Review Manager
>> 
>> _______________________________________________
>> swift-evolution-announce mailing list
>> swift-evolution-announce at swift.org
>> https://lists.swift.org/mailman/listinfo/swift-evolution-announce
> 
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution