[swift-evolution] [Review] SE-0067: Enhanced Floating Point Protocols

[Howard Lovatt]

>
> The review of "SE-0067: Enhanced Floating Point Protocols" begins now and
> runs through April 25. The proposal is available here:
>
>
> https://github.com/apple/swift-evolution/blob/master/proposals/0067-floating-point-protocols.md
>
>
>         * What is your evaluation of the proposal?
>

+1, a valuable addition, with a few details I think could be improved:

    1. Consistent naming:
        1.a. Use the xxxed form of naming rather than mixing xxxed and
xxxing, e.g. in Arithmetic use added instead of adding to be consistent
with divided etc. Both name forms are allowed in the guidelines but it is
odd to mix them in the same API. Also see point 2 below.
        1.b. Use isXxx or hasXxx if that reads better for methods that
return Bool
    2. For the Arithmetic protocol use symbols instead of names, e.g.
`infix +` instead of `added`.


>         * Is the problem being addressed significant enough to warrant a
> change to Swift?
>

Yes, I have needed this a number of times


>         * Does this proposal fit well with the feel and direction of Swift?
>

Yes


>         * If you have you used other languages or libraries with a similar
> feature, how do you feel that this proposal compares to those?
>

Yes, e.g. Java, very handy


>         * How much effort did you put into your review? A glance, a quick
> reading, or an in-depth study?
>

Read the proposal and corresponded on Swift-Evolution and previously on the
old Apple-dev forums about this issue.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20160420/10ff42c0/attachment.html>