<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The review of "SE-0067: Enhanced Floating Point Protocols" begins now and runs through April 25. The proposal is available here:<br>
<br>
<a href="https://github.com/apple/swift-evolution/blob/master/proposals/0067-floating-point-protocols.md" rel="noreferrer" target="_blank">https://github.com/apple/swift-evolution/blob/master/proposals/0067-floating-point-protocols.md</a><br>
<br><br>
* What is your evaluation of the proposal?<br></blockquote><div><br></div><div>+1, a valuable addition, with a few details I think could be improved:</div><div><br></div><div> 1. Consistent naming:</div><div> 1.a. Use the xxxed form of naming rather than mixing xxxed and xxxing, e.g. in Arithmetic use added instead of adding to be consistent with divided etc. Both name forms are allowed in the guidelines but it is odd to mix them in the same API. Also see point 2 below.</div><div> 1.b. Use isXxx or hasXxx if that reads better for methods that return Bool</div><div> 2. For the Arithmetic protocol use symbols instead of names, e.g. `infix +` instead of `added`.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* Is the problem being addressed significant enough to warrant a change to Swift?<br></blockquote><div><br></div><div>Yes, I have needed this a number of times</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* Does this proposal fit well with the feel and direction of Swift?<br></blockquote><div><br></div><div>Yes</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* If you have you used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br></blockquote><div><br></div><div>Yes, e.g. Java, very handy</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br></blockquote><div><br></div><div>Read the proposal and corresponded on Swift-Evolution and previously on the old Apple-dev forums about this issue. </div></div></div></div>