[swift-evolution] [swift-evolution-announce] [Review] SE-0037 Clarify interaction between comments & operators

davesweeris at mac.com davesweeris at mac.com
Fri Mar 11 14:00:43 CST 2016


That’s a good point. I was only thinking of the “/*…*/“ style. The inherent line breaks in the “//“ style make things much clearer.

- Dave Sweeris

> On Mar 11, 2016, at 1:41 PM, Jesse Rusak <me at jesserusak.com> wrote:
> 
>> 
>> On Mar 11, 2016, at 1:12 PM, Dave via swift-evolution <swift-evolution at swift.org <mailto:swift-evolution at swift.org>> wrote:
>> 
>> I’m sorta in favor… Reading the proposal, I agree that something needed to be done, but I think a better solution would’ve been to disallow comments between operators and their operands. Sorry, I didn’t see the thread about it, or I would’ve said something there.
> 
> I think there are cases where comments between operators & operands can be useful in long expressions. Arguably there are nicer ways to write this, but this pattern is pretty common in mathy code:
> 
> let total = (a +      // base amount
>              b / 2 +  // half of leftovers from last time
>              c + 1)   // fudge factor
> 
>> Anyway, if it’s this vs leaving it alone, then +1 for this.
>> 
>> -Dave Sweeris
>> 
>>> On Mar 11, 2016, at 12:00 PM, Chris Lattner <clattner at apple.com <mailto:clattner at apple.com>> wrote:
>>> 
>>> Hello Swift community,
>>> 
>>> The review of “Clarify interaction between comments & operators” begins now and runs through March 15, 2016. The proposal is available here:
>>> 
>>> 	https://github.com/apple/swift-evolution/blob/master/proposals/0037-clarify-comments-and-operators.md <https://github.com/apple/swift-evolution/blob/master/proposals/0037-clarify-comments-and-operators.md>
>>> 
>>> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at:
>>> 	https://lists.swift.org/mailman/listinfo/swift-evolution
>>> 
>>> or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:
>>> 
>>> What goes into a review?
>>> 
>>> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
>>> 
>>> 	• What is your evaluation of the proposal?
>>> 	• Is the problem being addressed significant enough to warrant a change to Swift?
>>> 	• Does this proposal fit well with the feel and direction of Swift?
>>> 	• If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
>>> 	• How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
>>> 
>>> More information about the Swift evolution process is available at:
>>> 
>>> https://github.com/apple/swift-evolution/blob/master/process.md
>>> 
>>> Thank you,
>>> 
>>> -Chris
>>> Review Manager
>>> _______________________________________________
>>> swift-evolution-announce mailing list
>>> swift-evolution-announce at swift.org
>>> https://lists.swift.org/mailman/listinfo/swift-evolution-announce
>> 
>> _______________________________________________
>> swift-evolution mailing list
>> swift-evolution at swift.org <mailto:swift-evolution at swift.org>
>> https://lists.swift.org/mailman/listinfo/swift-evolution <https://lists.swift.org/mailman/listinfo/swift-evolution>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20160311/65e70bf6/attachment.html>


More information about the swift-evolution mailing list