[swift-dev] Todo cleanups & such
David Sweeris
davesweeris at mac.com
Wed Nov 1 19:05:05 CDT 2017
In "SILFunction.h", line 171, it says,
/// The function's set of semantics attributes.
///
/// TODO: Why is this using a std::string? Why don't we use uniqued
/// StringRefs?
llvm::SmallVector<std::string, 1> SemanticsAttrSet;
As an outside contributor, seeing as how I have no idea why a std::string was used instead of a uniqued StringRef (or TBH, even what it means to "unique" a StringRef in this context), is this the sort of thing I should not worry about "fixing"?
- Dave Sweeris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-dev/attachments/20171101/11a76252/attachment.html>
More information about the swift-dev
mailing list