<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">In "SILFunction.h", line 171, it says,<div class=""><div style="margin: 0px; font-size: 18px; line-height: normal; font-family: 'Fantasque Sans Mono'; color: rgb(120, 142, 149); background-color: rgb(0, 57, 70);" class=""><span style="color: #a4b0b1" class=""> </span>/// The function's set of semantics attributes.</div><div style="margin: 0px; font-size: 18px; line-height: normal; font-family: 'Fantasque Sans Mono'; color: rgb(120, 142, 149); background-color: rgb(0, 57, 70);" class=""><span style="color: #a4b0b1" class=""> </span>///</div><div style="margin: 0px; font-size: 18px; line-height: normal; font-family: 'Fantasque Sans Mono'; color: rgb(120, 142, 149); background-color: rgb(0, 57, 70);" class=""><span style="color: #a4b0b1" class=""> </span>/// TODO: Why is this using a std::string? Why don't we use uniqued</div><div style="margin: 0px; font-size: 18px; line-height: normal; font-family: 'Fantasque Sans Mono'; color: rgb(120, 142, 149); background-color: rgb(0, 57, 70);" class=""><span style="color: #a4b0b1" class=""> </span>/// StringRefs?</div><div style="margin: 0px; font-size: 18px; line-height: normal; font-family: 'Fantasque Sans Mono'; color: rgb(164, 176, 177); background-color: rgb(0, 57, 70);" class=""> llvm::SmallVector<std::string, <span style="color: #e5493d" class="">1</span>> SemanticsAttrSet;</div></div><div class=""><br class=""></div><div class="">As an outside contributor, seeing as how I have no idea why a std::string was used instead of a uniqued StringRef (or TBH, even what it means to "unique" a StringRef in this context), is this the sort of thing I should <i class="">not</i> worry about "fixing"?</div><div class=""><br class=""></div><div class="">- Dave Sweeris</div></body></html>