[swift-dev] What's the best way to handle failing SourceKit tests?

Dmitri Gribenko gribozavr at gmail.com
Tue Apr 12 10:44:39 CDT 2016


On Mon, Apr 11, 2016 at 7:55 PM, Michael Buckley via swift-dev
<swift-dev at swift.org> wrote:
> Hi,
> I'm currently working on SR-1115, adding initializers to Int and Uint to
> convert from UnsafePointer, and after making my changes, the
> SourceKit/DocSupport/doc_swift_module.swift tests are failing. (Failures
> attached).
> Presumably this is because the new initializers affect the SourceKit
> mappings, but unfortunately, it looks like most of the changes are to key
> offsets, and while most of the offsets have increased by 115, not all of
> them have, and I'm not even sure increasing the offsets by 115 is the
> correct change. I could just make the test pass by increasing the offsets as
> shown in the test failure, I'm worried that this could end up creating an
> invalid test case, which in the worst case could hide SourceKit problems in
> the future.
> Since any changes to the standard library probably affect these tests, I was
> wondering what the best way to resolve these failures is. Thanks.
> _______________________________________________
> swift-dev mailing list
> swift-dev at swift.org
> https://lists.swift.org/mailman/listinfo/swift-dev

(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/

More information about the swift-dev mailing list