[swift-dev] SR-122 / CollectionsMoveIndices.swift Prototype

[Shawn Erickson]

If you can see a way that I can assist Austin let me know. I was
approaching it by systematically pulling in the API and implementation in a
passive way into the existing code. Then toggling things to see the scope
of changes that would be needed. Not sure what is the best way to attack
this. I will hold on that attempt for now.

See my pull request or fork for what little I had started (if you haven't
already).

https://github.com/shawnce/swift/pull/1/files
https://github.com/shawnce/swift/

-Shawn

On Sun, Feb 21, 2016 at 6:45 PM Austin Zheng <austinzheng at gmail.com> wrote:

> I copy-pasted the prototype code into Collections.swift (commenting out
> the old code), renamed the types that conflicted with the naming
> guidelines, and am going through the errors one at a time to get the
> project into a buildable state. This might take a few more days. Let me
> know if there are any objections to this approach.
>
> Austin
>
> > On Feb 21, 2016, at 6:21 PM, Dave Abrahams <dabrahams at apple.com> wrote:
> >
> > Until we open commit access, they still need one or more repos to push
> to and create PRs from. Seems better for them to have an org repo for that
> so other collaborators have a centralized place to go for the latest
> non-integrated work.
> >
> > Sent from my moss-covered three-handled family gradunza
> >
> >> On Feb 21, 2016, at 5:34 PM, Austin Zheng <austinzheng at gmail.com>
> wrote:
> >>
> >> Hi Dmitri (et al),
> >>
> >> I have no personal objection to pull requests. If PRs directly to the
> Swift project are the best way to do things, let's keep it that way.
> >>
> >> Austin
> >>
> >>> On Feb 21, 2016, at 5:24 PM, Dmitri Gribenko <gribozavr at gmail.com>
> wrote:
> >>>
> >>> On Sun, Feb 21, 2016 at 12:13 PM, Austin Zheng <austinzheng at gmail.com>
> wrote:
> >>>> Agreed. I created a GitHub organization
> >>>> ('swift-stdlib-opensource-collaborators'), and will try to invite the
> >>>> non-Apple ('outsider') folks to join. Once that's happened, maybe
> Shawn can
> >>>> move his fork under the organization, or one of us can fork the repo
> again.
> >>>
> >>> Hi Austin, Shawn,
> >>>
> >>> We're still working out the general policy for commit access for
> >>> non-Apple contributors.
> >>>
> >>> I'm trying to understand the situation better -- could you explain why
> >>> pull requests present too much overhead for this project?  Many Apple
> >>> engineers who have commit access find that the pull request approach
> >>> works better for their day-to-day work.
> >>>
> >>> My concern is that doing this work in a parallel organization hides
> >>> this project from other contributors who might be interested.  Also,
> >>> you would only get CI coverage in the primary Swift organization.  In
> >>> general, creating a parallel organization sends an ambiguous message
> >>> to other people working on the project.
> >>>
> >>> Furthermore, even Shawn started his work on this project with a pull
> >>> request against his fork (https://github.com/shawnce/swift/pull/1).
> >>>
> >>> Could we start with pull requests against the swift-3-indexing-model
> >>> branch in the primary repository, and possibly move to direct commits
> >>> later?
> >>>
> >>> Dmitri
> >>>
> >>> --
> >>> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> >>> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
> >>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-dev/attachments/20160222/312f9664/attachment.html>