<div dir="ltr">If you can see a way that I can assist Austin let me know. I was approaching it by systematically pulling in the API and implementation in a passive way into the existing code. Then toggling things to see the scope of changes that would be needed. Not sure what is the best way to attack this. I will hold on that attempt for now.<div><br></div><div>See my pull request or fork for what little I had started (if you haven't already).</div><div><br></div><div><a href="https://github.com/shawnce/swift/pull/1/files">https://github.com/shawnce/swift/pull/1/files</a></div><div><a href="https://github.com/shawnce/swift/">https://github.com/shawnce/swift/</a><br></div><div><br></div><div>-Shawn</div></div><br><div class="gmail_quote"><div dir="ltr">On Sun, Feb 21, 2016 at 6:45 PM Austin Zheng <<a href="mailto:austinzheng@gmail.com">austinzheng@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I copy-pasted the prototype code into Collections.swift (commenting out the old code), renamed the types that conflicted with the naming guidelines, and am going through the errors one at a time to get the project into a buildable state. This might take a few more days. Let me know if there are any objections to this approach.<br>
<br>
Austin<br>
<br>
> On Feb 21, 2016, at 6:21 PM, Dave Abrahams <<a href="mailto:dabrahams@apple.com" target="_blank">dabrahams@apple.com</a>> wrote:<br>
><br>
> Until we open commit access, they still need one or more repos to push to and create PRs from. Seems better for them to have an org repo for that so other collaborators have a centralized place to go for the latest non-integrated work.<br>
><br>
> Sent from my moss-covered three-handled family gradunza<br>
><br>
>> On Feb 21, 2016, at 5:34 PM, Austin Zheng <<a href="mailto:austinzheng@gmail.com" target="_blank">austinzheng@gmail.com</a>> wrote:<br>
>><br>
>> Hi Dmitri (et al),<br>
>><br>
>> I have no personal objection to pull requests. If PRs directly to the Swift project are the best way to do things, let's keep it that way.<br>
>><br>
>> Austin<br>
>><br>
>>> On Feb 21, 2016, at 5:24 PM, Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>> wrote:<br>
>>><br>
>>> On Sun, Feb 21, 2016 at 12:13 PM, Austin Zheng <<a href="mailto:austinzheng@gmail.com" target="_blank">austinzheng@gmail.com</a>> wrote:<br>
>>>> Agreed. I created a GitHub organization<br>
>>>> ('swift-stdlib-opensource-collaborators'), and will try to invite the<br>
>>>> non-Apple ('outsider') folks to join. Once that's happened, maybe Shawn can<br>
>>>> move his fork under the organization, or one of us can fork the repo again.<br>
>>><br>
>>> Hi Austin, Shawn,<br>
>>><br>
>>> We're still working out the general policy for commit access for<br>
>>> non-Apple contributors.<br>
>>><br>
>>> I'm trying to understand the situation better -- could you explain why<br>
>>> pull requests present too much overhead for this project? Many Apple<br>
>>> engineers who have commit access find that the pull request approach<br>
>>> works better for their day-to-day work.<br>
>>><br>
>>> My concern is that doing this work in a parallel organization hides<br>
>>> this project from other contributors who might be interested. Also,<br>
>>> you would only get CI coverage in the primary Swift organization. In<br>
>>> general, creating a parallel organization sends an ambiguous message<br>
>>> to other people working on the project.<br>
>>><br>
>>> Furthermore, even Shawn started his work on this project with a pull<br>
>>> request against his fork (<a href="https://github.com/shawnce/swift/pull/1" rel="noreferrer" target="_blank">https://github.com/shawnce/swift/pull/1</a>).<br>
>>><br>
>>> Could we start with pull requests against the swift-3-indexing-model<br>
>>> branch in the primary repository, and possibly move to direct commits<br>
>>> later?<br>
>>><br>
>>> Dmitri<br>
>>><br>
>>> --<br>
>>> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if<br>
>>> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>>*/<br>
>><br>
<br>
</blockquote></div>