[swift-corelibs-dev] Measurement Formatters & ICU

[Philippe Hausler]

+Daphne since she was the one who implemented the Darwin version of the unit and measurements and I think she has some ideas on how we could perhaps build a uniform version for Linux hosts.

Per the C++; the script for that phase probably needs a bit of love since we haven’t had a need for C++ to be built in CF. 

Is there a specific version of ICU that we need to pick that functionality up? As it stands we don’t have a upper version limit on ICU but if we had a portion of the ICU source in CF it would probably mean that we would get symbolic conflicts when linking against versions that already had that.

> On Aug 22, 2016, at 1:36 PM, Will Stanton via swift-corelibs-dev <swift-corelibs-dev at swift.org> wrote:
> 
> I recall the time formatter being deprecated in favor of measfmt, so you might be right that uatimeunitformat isn't needed. I think some functions in uatimeunitformat.cpp made combining units easier when calling from (then NS)DateComponentsFormatter, but perhaps that can be put functionality in a (Swift-)CFDateComponentsFormatter wrapper. (Not sure if Apple will come out with its own CFDateComponentsFormatter).
> 
> 
> I think this was what I had to change to get C++ working:
> https://github.com/apple/swift-corelibs-foundation/blob/master/lib/phases.py
> The includes for CompileCxx should be more like CompileC.
> 
> Regards,
> Will Stanton
> 
> Sent from my iPhone
> 
>> On Aug 22, 2016, at 15:58, Henry Betts via swift-corelibs-dev <swift-corelibs-dev at swift.org> wrote:
>> 
>> Yes - I was planning on including uameasureformat.cpp for the linux build, although I was also unsure whether the build script was setup to compile c++.
>> Noticed a bug in uameasureformat.cpp by the way; DURATION_DAY and DURATION_WEEK are the wrong way around!
>> 
>> I’m a bit confused by uatimeunitformat. I’m probably missing something obvious, but what can it do that uameasureformat can’t do?
> 
> _______________________________________________
> swift-corelibs-dev mailing list
> swift-corelibs-dev at swift.org
> https://lists.swift.org/mailman/listinfo/swift-corelibs-dev