[swift-corelibs-dev] f8c3fe6c breaks on Darwin

[Luke Howard]

Also, the NSData test is broken on Darwin when libdispatch is enabled – possibly the system DispatchData is being pulled in and something funny happens, this seems to work around it but I’m not sure if it is the correct fix:

+++ b/Foundation/NSData.swift
@@ -228,7 +228,7 @@ open class NSData : NSObject, NSCopying, NSMutableCopying, NSSecureCoding {
     }
     
     open override func isEqual(_ value: Any?) -> Bool {
-#if DEPLOYMENT_ENABLE_LIBDISPATCH
+#if DEPLOYMENT_ENABLE_LIBDISPATCH && !os(OSX)
         if let data = value as? DispatchData {
             if data.count != length {
                 return false


> On 23 Aug 2016, at 5:46 PM, Luke Howard via swift-corelibs-dev <swift-corelibs-dev at swift.org> wrote:
> 
> Enabling libdispatch seems to break the tests on Darwin because DEPLOYMENT_ENABLE_LIBDISPATCH is not added to the XCode project build flags (both for the C/Swift compilers).
> 
> --
> www.lukehoward.com <http://www.lukehoward.com/>
> soundcloud.com/lukehoward
> _______________________________________________
> swift-corelibs-dev mailing list
> swift-corelibs-dev at swift.org
> https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

--
www.lukehoward.com
soundcloud.com/lukehoward

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-corelibs-dev/attachments/20160823/6661a535/attachment.html>