<div dir="ltr">It just seems a little strange that @escaping only shows up once in the following example (real) function of mine yet both of them are escaping. This fixit message should maybe imply that @escaping isn't needed since the optional one is already implicitly considered escaping? ...it is kinda confusing when first jumping over to Swift if at one point you are told you need to added @escaping (the non-optional one) yet you are told @escaping isn't valid for the optional one despite it needing to be escaping (e.g. the fixit doesn't really explain that is already escaping).<div><br><div><div> func httpGet<T>(path: String, parameters: [String:String] = [:],</div><div> needsAuth: Bool = true, queue: DispatchQueue = DispatchQueue.main,</div><div> completion: ObjectFetchCallback<T>?, importer: @escaping HttpImporterCallback<T>)</div></div><div><br></div><div>-Shawn</div></div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Sep 7, 2016 at 6:51 PM Jacob Bandes-Storch <<a href="mailto:jtbandes@gmail.com">jtbandes@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div><div><div dir="ltr"><div>On Wed, Sep 7, 2016 at 5:54 PM, Michael Ilseman via swift-users <span dir="ltr"><<a href="mailto:swift-users@swift.org" target="_blank">swift-users@swift.org</a>></span> wrote:<br></div></div></div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div>I implemented a better (i.e. correct) diagnostic message for this at <a href="https://github.com/apple/swift/pull/4670" target="_blank">https://github.com/apple/swift/pull/4670</a>. I want to also do a better diagnostic specifically for aggregate parameters to functions (e.g. optional closures), but that requires more work in the type checker.</div><div><br></div><div>Basically, @escaping is valid only on closures in function parameter position. The noescape-by-default rule only applies to these closures at function parameter position, otherwise they are escaping. Aggregates, such as enums with associated values (e.g. Optional), tuples, structs, etc., if they have closures, follow the default rules for closures that are not at function parameter position, i.e. they are escaping.</div></div></blockquote><div><br></div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Shouldn't it be possible to allow distinguishing @escaping/@noescape for aggregates like these, at least for the simple case of Optional? (I handled optionals in <a href="https://github.com/apple/swift/pull/4438" target="_blank">https://github.com/apple/swift/pull/4438</a> for imported function types; see <a href="https://github.com/apple/swift/pull/4438#issuecomment-243645367" target="_blank">comment</a>.)</div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div><br></div><div>It would be a post-Swift-3 addition to the language to be able to support more robust liveness tracking here. There may be interesting directions to take this, with optional closures being the most common beneficiary. </div><div><div><div><br></div><div><blockquote type="cite"><div>On Sep 7, 2016, at 3:33 PM, Shawn Erickson via swift-users <<a href="mailto:swift-users@swift.org" target="_blank">swift-users@swift.org</a>> wrote:</div><br><div><div dir="ltr">I see <a href="https://bugs.swift.org/browse/SR-2324" target="_blank">https://bugs.swift.org/browse/SR-2324</a> and <a href="https://bugs.swift.org/browse/SR-2444" target="_blank">https://bugs.swift.org/browse/SR-2444</a> which looks related to this issue and may explain the error I saw on "the other side" of this.<div><br></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Sep 7, 2016 at 3:28 PM Shawn Erickson <<a href="mailto:shawnce@gmail.com" target="_blank">shawnce@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Yeah I actually have a few of those myself that I can no longer do.</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Sep 7, 2016 at 3:26 PM Jon Shier <<a href="mailto:jon@jonshier.com" target="_blank">jon@jonshier.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word">Perhaps relatedly, it no longer seems possible to mark typealiased closures as @escaping. That was quite handy when you know that closures will always be used asynchronously.<div><br></div><div><br></div><div>Jon</div><div><br></div><div><br><div><blockquote type="cite"></blockquote></div></div></div><div style="word-wrap:break-word"><div><div><blockquote type="cite"><div>On Sep 7, 2016, at 6:15 PM, Shawn Erickson via swift-users <<a href="mailto:swift-users@swift.org" target="_blank">swift-users@swift.org</a>> wrote:</div><br></blockquote></div></div></div><div style="word-wrap:break-word"><div><div><blockquote type="cite"><div><div dir="ltr">I should note that this issue also appeared in an earlier variant of Swift after the addition of @escaping but I was on vacation so didn't get a chance to report it then. It isn't new with the Xcode 8 GM.<br><br><div class="gmail_quote"><div dir="ltr">On Wed, Sep 7, 2016 at 3:08 PM Shawn Erickson <<a href="mailto:shawnce@gmail.com" target="_blank">shawnce@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">I like and fully supported the change to @escaping away from @noescape however in a body of code that I am porting to the latest Swift 3 variant (as found in Xcode 8 GM) I am hitting an issue for methods that take an optional completion closure. If optional is involved I can't find a way to apply @escape to the escaping closure. See the following for an basic example...<div><br></div><div>Is their a way to do what I need and/or is this an edge case in the implementation of @escaping?<br><div><br></div><div><div><font face="monospace" size="1">typealias MyCallback = (String)->()</font></div><div><font face="monospace" size="1"><br></font></div><div><font face="monospace" size="1">// Happy</font></div><div><font face="monospace" size="1">func foo1(bar: String, completion: ((String)->())) {</font></div><div><font face="monospace" size="1"> completion(bar)</font></div><div><font face="monospace" size="1">}</font></div><div><font face="monospace" size="1"><br></font></div><div><font face="monospace" size="1">// Happy</font></div><div><font face="monospace" size="1">func foo2(bar: String, completion: MyCallback) {</font></div><div><font face="monospace" size="1"> completion(bar)</font></div><div><font face="monospace" size="1">}</font></div><div><font face="monospace" size="1"><br></font></div><div><font face="monospace" size="1">// Happy</font></div><div><font face="monospace" size="1">func foo3(bar: String, completion: ((String)->())? = nil) {</font></div><div><font face="monospace" size="1"> completion?(bar)</font></div><div><font face="monospace" size="1">}</font></div><div><font face="monospace" size="1"><br></font></div><div><font face="monospace" size="1">// Happy</font></div><div><font face="monospace" size="1">func foo4(bar: String, completion: MyCallback? = nil) {</font></div><div><font face="monospace" size="1"> completion?(bar)</font></div><div><font face="monospace" size="1">}</font></div><div><font face="monospace" size="1"><br></font></div><div><font face="monospace" size="1">// Happy</font></div><div><font face="monospace" size="1">func foo5(bar: String, completion: Optional<MyCallback> = nil) {</font></div><div><font face="monospace" size="1"> completion?(bar)</font></div><div><font face="monospace" size="1">}</font></div><div><font face="monospace" size="1"><br></font></div><div><font face="monospace" size="1">// Happy</font></div><div><font face="monospace" size="1">func foo6(bar: String, completion: @escaping (String)->()) {</font></div><div><font face="monospace" size="1"> completion(bar)</font></div><div><font face="monospace" size="1">}</font></div><div><font face="monospace" size="1"><br></font></div><div><font face="monospace" size="1">// Happy</font></div><div><font face="monospace" size="1">func foo7(bar: String, completion: @escaping MyCallback) {</font></div><div><font face="monospace" size="1"> completion(bar)</font></div><div><font face="monospace" size="1">}</font></div><div><font face="monospace" size="1"><br></font></div><div><font face="monospace" size="1">// Unhappy...</font></div><div><font face="monospace" size="1">// "@escaping attribute only applies to function types"</font></div><div><font face="monospace" size="1">func foo8(bar: String, completion: @escaping ((String)->())? = nil) {</font></div><div><font face="monospace" size="1"> completion?(bar)</font></div><div><font face="monospace" size="1">}</font></div><div><font face="monospace" size="1"><br></font></div><div><font face="monospace" size="1">// Unhappy...</font></div><div><font face="monospace" size="1">// "@escaping attribute only applies to function types"</font></div><div><font face="monospace" size="1">func foo9(bar: String, completion: @escaping MyCallback? = nil) {</font></div><div><font face="monospace" size="1"> completion?(bar)</font></div><div><font face="monospace" size="1">}</font></div><div><font face="monospace" size="1"><br></font></div><div><font face="monospace" size="1">// Unhappy...</font></div><div><font face="monospace" size="1">// "@escaping attribute only applies to function types"</font></div><div><font face="monospace" size="1">func foo10(bar: String, completion: (@escaping ((String)->()))? = nil) {</font></div><div><font face="monospace" size="1"> completion?(bar)</font></div><div><font face="monospace" size="1">}</font></div><div><font face="monospace" size="1"><br></font></div><div><font face="monospace" size="1">// Unhappy...</font></div><div><font face="monospace" size="1">// "@escaping attribute only applies to function types"</font></div><div><font face="monospace" size="1">func foo11(bar: String, completion: (@escaping MyCallback)? = nil) {</font></div><div><font face="monospace" size="1"> completion?(bar)</font></div><div><font face="monospace" size="1">}</font></div><div><font face="monospace" size="1"><br></font></div><div><font face="monospace" size="1">// Unhappy...</font></div><div><font face="monospace" size="1">// "@escaping attribute only applies to function types"</font></div><div><font face="monospace" size="1">func foo12(bar: String, completion: Optional<@escaping MyCallback> = nil) {</font></div><div><font face="monospace" size="1"> completion?(bar)</font></div><div><font face="monospace" size="1">}</font></div></div></div></div></blockquote></div></div></div></blockquote></div></div></div><div style="word-wrap:break-word"><div><div><blockquote type="cite"><div>
_______________________________________________<br>swift-users mailing list<br><a href="mailto:swift-users@swift.org" target="_blank">swift-users@swift.org</a><br><a href="https://lists.swift.org/mailman/listinfo/swift-users" target="_blank">https://lists.swift.org/mailman/listinfo/swift-users</a><br></div></blockquote></div><br></div></div></blockquote></div></blockquote></div>
_______________________________________________<br>swift-users mailing list<br><a href="mailto:swift-users@swift.org" target="_blank">swift-users@swift.org</a><br><a href="https://lists.swift.org/mailman/listinfo/swift-users" target="_blank">https://lists.swift.org/mailman/listinfo/swift-users</a><br></div></blockquote></div><br></div></div></div><br>_______________________________________________<br>
swift-users mailing list<br>
<a href="mailto:swift-users@swift.org" target="_blank">swift-users@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-users" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-users</a><br>
<br></blockquote></div></div></div></blockquote></div>