<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Do you have the optimizer enabled (using -O)? I see inlining happening as you'd expect. This:<div class=""><br class=""></div><div class=""><div class="">let x = Vector2(x: 1, y: 1)</div><div class="">foo(x.x)</div><div class="">foo(x.r)</div><div class=""><br class=""></div><div class="">optimizes down to:</div><div class=""><br class=""></div><div class=""><div style="margin: 0px; font-size: 10px; line-height: normal; font-family: Menlo;" class=""> %15 = integer_literal $Builtin.Int64, 1 // user: %16</div><div style="margin: 0px; font-size: 10px; line-height: normal; font-family: Menlo;" class=""> %16 = struct $Int (%15 : $Builtin.Int64) // users: %17, %17, %20, %21</div><div style="margin: 0px; font-size: 10px; line-height: normal; font-family: Menlo;" class=""> %17 = struct $Vector2<Int> (%16 : $Int, %16 : $Int) // user: %18</div><div style="margin: 0px; font-size: 10px; line-height: normal; font-family: Menlo;" class=""> // function_ref foo.foo (Swift.Int) -> ()</div><div style="margin: 0px; font-size: 10px; line-height: normal; font-family: Menlo;" class=""> %19 = function_ref @_TF3foo3fooFSiT_ : $@convention(thin) (Int) -> () // users: %20, %21</div><div style="margin: 0px; font-size: 10px; line-height: normal; font-family: Menlo;" class=""> %20 = apply %19(%16) : $@convention(thin) (Int) -> ()</div><div style="margin: 0px; font-size: 10px; line-height: normal; font-family: Menlo;" class=""> %21 = apply %19(%16) : $@convention(thin) (Int) -> ()</div></div><div class=""><br class=""></div><div class="">forwarding the constant 1 from the Vector2 constructor to foo as one would hope the optimizer would.</div><div class=""><br class=""></div><div class="">-Joe</div><div class=""><br class=""></div><div><blockquote type="cite" class=""><div class="">On Dec 18, 2015, at 12:07 PM, David Turnbull via swift-users <<a href="mailto:swift-users@swift.org" class="">swift-users@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I'm working on a math library for OpenGL. At the core of this are, of course, scalar types. The scalars are grouped into vectors of length 2, 3, and 4. The vectors are used to build matrices of all variations from 2x2 to 4x4.<div class=""><br class=""></div><div class="">In order to be performant, scalars, vectors, and matrices must all be values types aka structs. This way, for example, an Array<Vector3<Float>> can be passed directly to OpenGL without any copying. In my testing so far, Swift does this quite well.</div><div class=""><br class=""></div><div class="">Ideally, I'd do something like this:</div><div class=""><br class=""></div><div class=""><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><span style="color:rgb(187,44,162)" class="">public struct</span> Vector2<T:ScalarType> : Array<T, <span style="color:rgb(39,42,216)" class="">2</span>> {</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> <span style="color:rgb(187,44,162)" class="">public</span> <span style="color:rgb(187,44,162)" class="">var</span> x:<span style="color:rgb(112,61,170)" class="">T</span> { <span style="color:rgb(187,44,162)" class="">get</span> {<span style="color:rgb(187,44,162)" class="">return</span> <span style="color:rgb(187,44,162)" class="">self</span>[<span style="color:rgb(39,42,216)" class="">0</span>]} <span style="color:rgb(187,44,162)" class="">set</span> {<span style="color:rgb(187,44,162)" class="">self</span>[<span style="color:rgb(39,42,216)" class="">0</span>] = newValue} }</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> <span style="color:rgb(187,44,162)" class="">public</span> <span style="color:rgb(187,44,162)" class="">var</span> y:<span style="color:rgb(112,61,170)" class="">T</span> { <span style="color:rgb(187,44,162)" class="">get</span> {<span style="color:rgb(187,44,162)" class="">return</span> <span style="color:rgb(187,44,162)" class="">self</span>[<span style="color:rgb(39,42,216)" class="">1</span>]} <span style="color:rgb(187,44,162)" class="">set</span> {<span style="color:rgb(187,44,162)" class="">self</span>[<span style="color:rgb(39,42,216)" class="">1</span>] = newValue} }</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class="">}</div></div><div class=""><br class=""></div><div class="">But there's so much wrong with that. You can't use inheritance with structs. Array isn't really a struct; the docs say it is but really it's a reference to a special copy-on-write value type. Array can't be a fixed size. You can't use literals with generic placeholders. Ok, fine, I accept this isn't C++, let's move on to something Swifty.</div><div class=""><br class=""></div><div class=""><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><span style="color:rgb(187,44,162)" class="">public</span> <span style="color:rgb(187,44,162)" class="">struct</span> Vector2<T:ScalarType> {<br class=""></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> <span style="color:rgb(187,44,162)" class="">public</span> <span style="color:rgb(187,44,162)" class="">var</span> x:<span style="color:rgb(112,61,170)" class="">T</span>, y:<span style="color:rgb(112,61,170)" class="">T</span></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo; min-height: 13px;" class=""><br class=""></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> <span style="color:rgb(187,44,162)" class="">public</span> <span style="color:rgb(187,44,162)" class="">var</span> r:<span style="color:rgb(112,61,170)" class="">T</span> { <span style="color:rgb(187,44,162)" class="">get</span> {<span style="color:rgb(187,44,162)" class="">return</span> <span style="color:rgb(79,129,135)" class="">x</span>} <span style="color:rgb(187,44,162)" class="">set</span> {<span style="color:rgb(79,129,135)" class="">x</span> = newValue} }</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> <span style="color:rgb(187,44,162)" class="">public</span> <span style="color:rgb(187,44,162)" class="">var</span> g:<span style="color:rgb(112,61,170)" class="">T</span> { <span style="color:rgb(187,44,162)" class="">get</span> {<span style="color:rgb(187,44,162)" class="">return</span> <span style="color:rgb(79,129,135)" class="">y</span>} <span style="color:rgb(187,44,162)" class="">set</span> {<span style="color:rgb(79,129,135)" class="">y</span> = newValue} }</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo; min-height: 13px;" class=""><br class=""></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> <span style="color:rgb(187,44,162)" class="">public</span> <span style="color:rgb(187,44,162)" class="">var</span> s:<span style="color:rgb(112,61,170)" class="">T</span> { <span style="color:rgb(187,44,162)" class="">get</span> {<span style="color:rgb(187,44,162)" class="">return</span> <span style="color:rgb(79,129,135)" class="">x</span>} <span style="color:rgb(187,44,162)" class="">set</span> {<span style="color:rgb(79,129,135)" class="">x</span> = newValue} }</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> <span style="color:rgb(187,44,162)" class="">public</span> <span style="color:rgb(187,44,162)" class="">var</span> t:<span style="color:rgb(112,61,170)" class="">T</span> { <span style="color:rgb(187,44,162)" class="">get</span> {<span style="color:rgb(187,44,162)" class="">return</span> <span style="color:rgb(79,129,135)" class="">y</span>} <span style="color:rgb(187,44,162)" class="">set</span> {<span style="color:rgb(79,129,135)" class="">y</span> = newValue} }</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo; min-height: 13px;" class=""><br class=""></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> <span style="color:rgb(187,44,162)" class="">public</span> <span style="color:rgb(187,44,162)" class="">subscript</span>(i: <span style="color:rgb(112,61,170)" class="">Int</span>) -> <span style="color:rgb(112,61,170)" class="">T</span> {</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> <span style="color:rgb(187,44,162)" class="">get</span> {</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> <span style="color:rgb(187,44,162)" class="">switch</span>(i) {</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> <span style="color:rgb(187,44,162)" class="">case</span> <span style="color:rgb(39,42,216)" class="">0</span>: <span style="color:rgb(187,44,162)" class="">return</span> <span style="color:rgb(79,129,135)" class="">x</span></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> <span style="color:rgb(187,44,162)" class="">case</span> <span style="color:rgb(39,42,216)" class="">1</span>: <span style="color:rgb(187,44,162)" class="">return</span> <span style="color:rgb(79,129,135)" class="">y</span></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> <span style="color:rgb(187,44,162)" class="">default</span>: <span style="color:rgb(61,29,129)" class="">fatalError</span>()</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> }</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> }</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> <span style="color:rgb(187,44,162)" class="">set</span> {</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> <span style="color:rgb(187,44,162)" class="">switch</span>(i) {</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> <span style="color:rgb(187,44,162)" class="">case</span> <span style="color:rgb(39,42,216)" class="">0</span>: <span style="color:rgb(79,129,135)" class="">x</span> = newValue</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> <span style="color:rgb(187,44,162)" class="">case</span> <span style="color:rgb(39,42,216)" class="">1</span>: <span style="color:rgb(79,129,135)" class="">y</span> = newValue</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> <span style="color:rgb(187,44,162)" class="">default</span>: <span style="color:rgb(61,29,129)" class="">fatalError</span>()</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> }</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> }</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> }</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class="">}</div></div><div class=""><br class=""></div><div class="">Functionally, this works fine. The x and y properties are the struct data. I can access vectors with subscripts, both coordinate properties, and color properties It's exactly what someone using an OpenGL vector type would expect. You can make these into arrays, use them in other structs which are made into arrays, and pass them to OpenGL just fine.</div><div class=""><br class=""></div><div class="">But I hit some performance issues. Let's use myvec.x as a baseline. This is always inlined and as fast as C.</div><div class=""><br class=""></div><div class="">You might expect myvec.r to have the same performance. It does in other languages but not Swift. The performance penalty is 20X. Yes, twenty times slower than myvec.x. The performance hit comes entirely from dynamic dispatch. 10X because it's not inlined, and another 10X because Vector2 is a template.</div><div class=""><br class=""></div><div class="">I can get rid of 10X of that by writing my own preprocessor for the template. There's only four scalar types that are valid for OpenGL so this really isn't that hard. But it's not a complete solution and preprocessing core languages features only to gain performance is an indication the compiler isn't doing optimization as well as it could.</div><div class=""><br class=""></div><div class="">Subscript access is the same 20X slower for the same reasons. The switch disappears into the noise. But I'm still tempted to use a precondition and cast to an UnsafePointer.</div><div class=""><br class=""></div><div class="">I'm aware you can mark a class final and a method private to enable inlining. Except this isn't a class and making the API private, well, it's not an API then. Forcing @inline(__always) doesn't seem to do anything.</div><div class=""><br class=""></div><div class="">Perhaps I could just not make this a module and leave everything internal. Supposedly it'd be inlined when whole module optimization is enabled. Except that doesn't happen.</div><div class=""><br class=""></div><div class="">How can I get these property aliases to be inlined? Is it possible today? Will it be possible in the future? Is there a different pattern for vectors that's better suited to the task?</div><div class=""><br class=""></div><div class="">-david (<a href="https://github.com/AE9RB/SwiftGL" class="">https://github.com/AE9RB/SwiftGL</a>)</div><div class=""><br class=""></div><div class=""><br class=""></div></div>
<img src="https://u2002410.ct.sendgrid.net/wf/open?upn=RoDF4MveSEMYBIqIJA6ub1g8cOZ-2BVYvqV-2FqygPhjPn8MpF3Xuds993lZR4HOlyiwZAJysveufABQxFihu2gYKoTziSw4u2T7rBbJJ505MR08C-2BIdXoqvKYv2EFpUm6V244BMNxCNumioPMq-2Fe7m-2Bp3y-2BGEJfYZ5Gl4doRdHEdJJUprzvxWqUo5A-2Bg0PxmZs17ZR-2BBErijj4QwWoQ2x5ATf-2Bo2gb3zi53A2f17DeS38k-3D" alt="" width="1" height="1" border="0" style="height:1px !important;width:1px !important;border-width:0 !important;margin-top:0 !important;margin-bottom:0 !important;margin-right:0 !important;margin-left:0 !important;padding-top:0 !important;padding-bottom:0 !important;padding-right:0 !important;padding-left:0 !important;" class="">
_______________________________________________<br class="">swift-users mailing list<br class=""><a href="mailto:swift-users@swift.org" class="">swift-users@swift.org</a><br class="">https://lists.swift.org/mailman/listinfo/swift-users<br class=""></div></blockquote></div><br class=""></div></body></html>