<html><body><p><font size="2">Hi Georgios,</font><br><br><font size="2">I created this: </font><a href="https://github.com/gtaban/TLSService/issues/7"><font size="2">https://github.com/gtaban/TLSService/issues/7</font></a><br><br><font size="2">But this is related to the point raised by Brent:</font><br><br><font size="2">> > * The buffer-based `willSend` and `willReceive` calls ought to use `UnsafeRawBufferPointer` and </font><br><font size="2">> > `UnsafeMutableRawBufferPointer` instead of passing the pointer and size as separate parameters. </font><br><font size="2">> > This `willSend` variant should also be unlabeled.</font><br><font size="2">> </font><br><font size="2">> Makes sense but tbh I was intending to remove those APIs and only support Data. The data type that these methods </font><br><font size="2">> support depend on the what the socket class will support, which as far as I understand, have not been defined yet.</font><br><font size="2">> </font><br><font size="2">> Do you think it still makes sense for us to include the Unsafe[Mutable]RawBufferPointer versions of the APIs?</font><br><br><font size="2">If we convert to using buffers, we can omit size altogether. Any thoughts on above?</font><br><br><font size="2">g.</font><br><br><br><img width="16" height="16" src="cid:1__=8FBB0BC1DFDC6E2B8f9e8a93df938690918c8FB@" border="0" alt="Inactive hide details for Georgios Moschovitis ---07/02/2017 12:11:37 AM---Great work, thank you. One minor thing, I find the p"><font size="2" color="#424282">Georgios Moschovitis ---07/02/2017 12:11:37 AM---Great work, thank you. One minor thing, I find the parameter name `bufSize` to be non-swifty. Please</font><br><br><font size="2" color="#5F5F5F">From: </font><font size="2">Georgios Moschovitis <george.moschovitis@icloud.com></font><br><font size="2" color="#5F5F5F">To: </font><font size="2">Gelareh Taban <gtaban@us.ibm.com></font><br><font size="2" color="#5F5F5F">Cc: </font><font size="2">swift-server-dev@swift.org</font><br><font size="2" color="#5F5F5F">Date: </font><font size="2">07/02/2017 12:11 AM</font><br><font size="2" color="#5F5F5F">Subject: </font><font size="2">Re: [swift-server-dev] TLSService mini-release</font><br><hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br><br><br><tt><font size="2">Great work, thank you.<br><br>One minor thing, I find the parameter name `bufSize` to be non-swifty. Please consider changing to e.g. `bufferSize` (or even `count`).<br><br>-g.<br></font></tt><br><br><BR>
</body></html>