<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">I’m thinking that maybe It will be better to make both major/minor Int16/UInt16 instead, since the value we get from the http parser is an unsigned short, and making it a short help write the hash as the following without worrying about overflow due to bad programming from user. <div class=""><br class=""><div class="">var hashValue: Int { return Int(major) << 16 &+ Int(minor) } </div><div class=""><br class=""></div><div class="">may be a bit over engineering. Just a thought</div><div class=""><br class=""></div><div class="">Michael.</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jun 13, 2017, at 1:44 PM, Chris Bailey via swift-server-dev <<a href="mailto:swift-server-dev@swift.org" class="">swift-server-dev@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><font size="2" face="sans-serif" class="">Based on our discussed approach of reviewing
each of the types in the HTTP project, I've raised the following PR to
convert HTTPVersion from (Int, Int) to a struct based on Paulo's proposal:</font>
<br class=""><font size="2" face="sans-serif" class=""> </font><a href="https://github.com/swift-server/http/pull/6" class=""><font size="2" color="blue" face="sans-serif" class="">https://github.com/swift-server/http/pull/6</font></a>
<br class="">
<br class=""><font size="2" face="sans-serif" class="">I've not yet added Hashable, Equatable
and CustomStringConvertible protocols - we can do that if we're happy with
the change.</font>
<br class="">
<br class=""><font size="2" face="sans-serif" class="">Chris<br class="">
Unless stated otherwise above:<br class="">
IBM United Kingdom Limited - Registered in England and Wales with number
741598. <br class="">
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
3AU<br class="">
</font>_______________________________________________<br class="">swift-server-dev mailing list<br class=""><a href="mailto:swift-server-dev@swift.org" class="">swift-server-dev@swift.org</a><br class="">https://lists.swift.org/mailman/listinfo/swift-server-dev<br class=""></div></blockquote></div><br class=""></div></div></body></html>