<p dir="ltr">I think that's irrelevant, at this point.</p>
<br><div class="gmail_quote"><div dir="ltr">On Thu, Jun 1, 2017, 11:57 Carl Brown via swift-server-dev <<a href="mailto:swift-server-dev@swift.org">swift-server-dev@swift.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
> On Jun 1, 2017, at 3:35 AM, Alex Blewitt <<a href="mailto:alblue@apple.com" target="_blank">alblue@apple.com</a>> wrote:<br>
><br>
>> On 31 May 2017, at 23:27, Carl Brown via swift-server-dev <<a href="mailto:swift-server-dev@swift.org" target="_blank">swift-server-dev@swift.org</a>> wrote:<br>
>><br>
>> That's normal (or at least expected).<br>
>><br>
>> To make the tests run faster, I force-close the sockets at the end of each of the XCTests instead of waiting for a graceful cleanup. The Socket library sees that as an error (which it would be, if it happened under normal circumstances).<br>
><br>
> Where does the error printing happen? If it's in Swift, can we suppress it so that ti doesn't confuse people who are running the tests in future?<br>
><br>
> Alex<br>
<br>
<br>
It's in Swift, but it's several layers of encapsulation removed from the tests, and in many different places.<br>
<br>
I started an implementation where there was a boolean flag that indicated that the socket had been forced-closed and that errors needed to be suppressed, and that flag was propagated down the call stack, but it turned out to make the code a lot harder to read.<br>
<br>
For this stage of the prototype, we thought that shorter and cleaner we could get the code, the easier it would be to discuss and share with the community.<br>
<br>
If the consensus is that the community thinks the trade off is worth it, it's not very hard to put in, but it complicates all the development going forward.<br>
<br>
What does everyone think?<br>
<br>
-Carl<br>
_______________________________________________<br>
swift-server-dev mailing list<br>
<a href="mailto:swift-server-dev@swift.org" target="_blank">swift-server-dev@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-server-dev" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-server-dev</a><br>
</blockquote></div>