<div dir="ltr">> <font size="2" face="sans-serif"><b>Paulo:</b> As an relatively small starting point, do you want to raise a PR to discuss making HTTPVersion a struct?</font><span style="font-size:12.800000190734863px"> </span><div><span style="font-size:12.800000190734863px"><br></span></div><div><span style="font-size:12.800000190734863px">OK! I'll send a PR tomorow!</span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 31 May 2017 at 19:27, Carl Brown via swift-server-dev <span dir="ltr"><<a href="mailto:swift-server-dev@swift.org" target="_blank">swift-server-dev@swift.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">That's normal (or at least expected).<br>
<br>
To make the tests run faster, I force-close the sockets at the end of each of the XCTests instead of waiting for a graceful cleanup. The Socket library sees that as an error (which it would be, if it happened under normal circumstances).<br>
<br>
-Carl<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
> On May 31, 2017, at 5:20 PM, Helge Heß via swift-server-dev <<a href="mailto:swift-server-dev@swift.org">swift-server-dev@swift.org</a>> wrote:<br>
><br>
> OK,<br>
><br>
> I tried to try that :-) As discussed there is no sample tool to run, so I tried<br>
><br>
> swift test<br>
><br>
> that gives me plenty of errors, e.g.:<br>
> --—snip--<br>
> Started server on port 61788 with 4 Serial Queues of each type and 8 accept sockets<br>
> Test testHelloEndToEnd() on port 61788<br>
> Error accepting client connection: Error code: -9994(0x-270A), Software caused connection abort<br>
> …<br>
> Started server on port 61791 with 4 Serial Queues of each type and 8 accept sockets<br>
> Test testRequestEchoEndToEnd() on port 61791<br>
> ReaderSource Event Error: Error code: -9982(0x-26FE), Bad file descriptor<br>
> Error accepting client connection: Error code: -9994(0x-270A), Software caused connection abort<br>
> —snap—<br>
><br>
> etc. Yet I get<br>
><br>
> Test Suite 'All tests' passed at 2017-06-01 00:13:50.769.<br>
> Executed 11 tests, with 0 failures (0 unexpected) in 0.226 (0.227) seconds<br>
><br>
> Is this expected behaviour?<br>
><br>
> Or how do you run this code? :-)<br>
><br>
> hh<br>
><br>
><br>
> On 31. May 2017, at 21:26, Chris Bailey via swift-server-dev <<a href="mailto:swift-server-dev@swift.org">swift-server-dev@swift.org</a>> wrote:<br>
>> As promised, I've moved the code over from carlbrown/HTTPSketch to swift-server/http into a "develop" branch:<br>
>> <a href="https://github.com/swift-server/http/tree/develop" rel="noreferrer" target="_blank">https://github.com/swift-<wbr>server/http/tree/develop</a><br>
>><br>
>> There's been three minor changes:<br>
>> • I've updated the licence to match the Swift.org licence and added copyright headers<br>
>> • I've added a API.md file to describe what the current API in the branch is<br>
>> • Carl has moved SimpleResponseCreator into Tests<br>
>> The next step is to go through a staged review. As its WWDC/AltConf/etc next week a number of people will be busy, as such it doesn't make sense to have a strict schedule until after next week. Having said that, we should try to make progress and close down/agree on some of the types if we can.<br>
>><br>
>> Paulo: As an relatively small starting point, do you want to raise a PR to discuss making HTTPVersion a struct?<br>
>><br>
>> If can close that down it might make sense to then move onto HTTPMethod and HTTPResponseStatus/HTTPStatus as those are again relatively small and we might be able to close them out during the busy week.<br>
>><br>
>> Chris<br>
>><br>
>><br>
>><br>
>><br>
>> From: Chris Bailey via swift-server-dev <<a href="mailto:swift-server-dev@swift.org">swift-server-dev@swift.org</a>><br>
>> To: <<a href="mailto:swift-server-dev@swift.org">swift-server-dev@swift.org</a>><br>
>> Date: 30/05/2017 19:13<br>
>> Subject: [swift-server-dev] HTTP API: prototype review process<br>
>> Sent by: <a href="mailto:swift-server-dev-bounces@swift.org">swift-server-dev-bounces@<wbr>swift.org</a><br>
>><br>
>><br>
>><br>
>> I've had some discussions with Paulo and David Ask offline, and below is the proposal from Paulo on how we proceed:<br>
>> • Move the HTTP Sketch prototype (of Johannes' API proposal) into the swift-server repo<br>
>> This will go into a “develop” branch rather than "master", but will have a MVP semver tag so it can be included via SwiftPM for people to test and benchmark with.<br>
>> • Have a staged review of the types and APIs<br>
>> In order to make sure that we have full "review coverage", we'll structure reviewing and reaching agreement on the types and APIs, including having deadlines for discussion, updates and reaching a conclusion.<br>
>> • Reviewed types and APIs are then merged into master<br>
>> Once a set of types or APIs have been reviewed, AND they build, pass tests with at least (95%?) coverage, 100% doc coverage, have generated jazzy docs and as well as design docs including the rationale for design decisions.<br>
>> • When the full set of types and APIs have been reviewed and merged to master, raise a Swift Evolution Proposal<br>
>> Once there is a full implementation in master, the API spec will go forward as a Swift Evolution Proposal to get feedback from the wider community. Once the feedback from the community is included, we can look at tagging a 1.0.0 release based on master.<br>
>><br>
>> We'll also document the API separately etc as suggested by Helge Heß. If this seems like a reasonable approach, we'll move the prototype code over to the swift-server org into a "develop" branch tomorrow.<br>
>><br>
>> Chris<br>
>> Unless stated otherwise above:<br>
>> IBM United Kingdom Limited - Registered in England and Wales with number 741598.<br>
>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU___________________________<wbr>____________________<br>
>> swift-server-dev mailing list<br>
>> <a href="mailto:swift-server-dev@swift.org">swift-server-dev@swift.org</a><br>
>> <a href="https://lists.swift.org/mailman/listinfo/swift-server-dev" rel="noreferrer" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-server-<wbr>dev</a><br>
>><br>
>><br>
>><br>
>> Unless stated otherwise above:<br>
>> IBM United Kingdom Limited - Registered in England and Wales with number 741598.<br>
>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU<br>
>> ______________________________<wbr>_________________<br>
>> swift-server-dev mailing list<br>
>> <a href="mailto:swift-server-dev@swift.org">swift-server-dev@swift.org</a><br>
>> <a href="https://lists.swift.org/mailman/listinfo/swift-server-dev" rel="noreferrer" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-server-<wbr>dev</a><br>
><br>
> ______________________________<wbr>_________________<br>
> swift-server-dev mailing list<br>
> <a href="mailto:swift-server-dev@swift.org">swift-server-dev@swift.org</a><br>
> <a href="https://lists.swift.org/mailman/listinfo/swift-server-dev" rel="noreferrer" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-server-<wbr>dev</a><br>
<br>
______________________________<wbr>_________________<br>
swift-server-dev mailing list<br>
<a href="mailto:swift-server-dev@swift.org">swift-server-dev@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-server-dev" rel="noreferrer" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-server-<wbr>dev</a><br>
</div></div></blockquote></div><br></div>