<p dir="ltr">Saying that most people expect an HTTP request/response to be a reference type is a claim that needs some numbers to back it up. I'm an evidence of a person that expects them to be value types. I didn't count how many in this thread expressed positive feelings about value types over reference types, but I get the general feeling that most people are favoring value types. Even if that's the case, "most people expect request/response to be a value type", that's not the best reason to do it so. We should choose the best semantics in a technical sense not just because people expect it. After we do that, people will know which semantics the types follow because we will document it. Then there won't be any confusion about which semantics is being used. </p>
<br><div class="gmail_quote"><div dir="ltr">On Mon, Mar 27, 2017, 10:31 Tanner Nelson via swift-server-dev <<a href="mailto:swift-server-dev@swift.org">swift-server-dev@swift.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="gmail_msg">Re: performance,<div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">I did a quick test of inout struct vs. class performance. The code can be found here: <a href="https://github.com/tanner0101/request-types" class="gmail_msg" target="_blank">https://github.com/tanner0101/request-types</a></div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">I found only a marginal increase in performance (~5%) in favor of inout value types. <a href="https://github.com/tanner0101/request-types/issues/1" class="gmail_msg" target="_blank">https://github.com/tanner0101/request-types/issues/1</a></div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Additionally, non-inout value types were a lot slower. This is obvious to the seasoned Swift dev considering each middleware in the test modifies and thus must copy the request. But this is the exact type of performance issue you can expect developers to create when interacting with "non-obvious value types". HTTP request/response being non-obvious value types compared to something like an integer or a float. (I'd argue the majority of web developers would expect request/response to be a reference type and thus easily forget or not know to use `inout`)</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Please feel free to submit any prs/issues/comments about ways I could improve this test to make it more accurate. </div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">tl;dr: value types don't seem much faster than reference types (especially considering dangers of misuse) in a simulated web framework scenario</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">inb4: people saying that the request/response models in my test are incomplete/not fully implemented/bad. this is _not_ a proposed api for request/response.</div><div class="gmail_msg"><br class="gmail_msg"><div class="gmail_msg">
<div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word" class="gmail_msg"><div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word" class="gmail_msg"><div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word" class="gmail_msg"><div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word" class="gmail_msg"><div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word" class="gmail_msg"><div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word" class="gmail_msg"><div style="font-variant-caps:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg"><div style="color:rgb(0,0,0)" class="gmail_msg"><font color="#9dacd1" class="gmail_msg">Va</font><font color="#aeb2cf" class="gmail_msg">p</font><font color="#c8bacd" class="gmail_msg">o</font><font color="#d0becc" class="gmail_msg">r</font><font color="#9dacd1" class="gmail_msg"> </font></div><div class="gmail_msg"><font color="#676767" class="gmail_msg"><a href="mailto:tanner@vapor.codes" class="gmail_msg" target="_blank">tanner@vapor.codes</a></font></div></div></div></div></div></div></div></div>
</div>
<br class="gmail_msg"><div class="gmail_msg"><blockquote type="cite" class="gmail_msg"></blockquote></div></div></div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><div class="gmail_msg"><blockquote type="cite" class="gmail_msg"><div class="gmail_msg">On Mar 27, 2017, at 1:55 PM, Michael Chiu via swift-server-dev <<a href="mailto:swift-server-dev@swift.org" class="gmail_msg" target="_blank">swift-server-dev@swift.org</a>> wrote:</div><br class="m_-2010893301835621454Apple-interchange-newline gmail_msg"></blockquote></div></div></div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><div class="gmail_msg"><blockquote type="cite" class="gmail_msg"><div class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"><blockquote type="cite" class="gmail_msg">On Mar 27, 2017, at 5:13 AM, Logan Wright via swift-server-dev <<a href="mailto:swift-server-dev@swift.org" class="gmail_msg" target="_blank">swift-server-dev@swift.org</a>> wrote:<br class="gmail_msg">If people feel extremely strong that there needs to be a concrete type, then I'd like to push for reference type as much as possible. As far as reference vs value type, I haven't really heard an argument for value types beyond what feels like a reaction to value types being the hip new hotness. While yes, they're great in Swift, and there's tons of places that should absolutely be modeled with value semantics, a request/response interaction represents a single request and should definitely be a reference based interaction.<br class="gmail_msg"></blockquote><br class="gmail_msg">I disagree with this one. First of all I think most of the framework pass the request and response as inout argument, if that is the case there shouldn’t be much copy overhead in the run loop. Second the problem of reference type is that everywhere the request and response exists could possibly mutate the res/req, and it affect globally. It is true that in normal use there shouldn’t be two place simultaneously operate on the same request but that could happen. (Therefore protocol is the best isn’t it)<br class="gmail_msg"><br class="gmail_msg"><blockquote type="cite" class="gmail_msg">In practice, we went through several model iterations and the value type created very high levels of bugs and confusion for end users. The three biggest problems we had were as follows:<br class="gmail_msg"><br class="gmail_msg">- Greatly increased bug levels and confusion related to unexpected mutation<br class="gmail_msg">- Unnecessary code requirements added to every single passive access (ie: middleware) increasing code bloat unnecessarily<br class="gmail_msg">- Extreme performance loss due to massive copy overhead<br class="gmail_msg"><br class="gmail_msg">Each of these problems evaporated pretty instantaneously when moving to reference types; it made it significantly easier to reason about for end users. <br class="gmail_msg"></blockquote>Just for curiosity, I’m very interested in the unexpected mutation of value semantic, I have always had an impression of value semantic are more free from unexpected mutation. <br class="gmail_msg"><br class="gmail_msg"><blockquote type="cite" class="gmail_msg">Would like to remind again for those that skipped above reading that our goal is not to build a web framework here, but rather to build small tools that make building frameworks slightly easier for library maintainers and creators. <br class="gmail_msg"></blockquote>That’s so true lol.<br class="gmail_msg"><br class="gmail_msg">Michael.<br class="gmail_msg"><br class="gmail_msg"></div></div></blockquote></div></div></div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><div class="gmail_msg"><blockquote type="cite" class="gmail_msg"><div class="gmail_msg"><div class="gmail_msg">_______________________________________________<br class="gmail_msg">swift-server-dev mailing list<br class="gmail_msg"><a href="mailto:swift-server-dev@swift.org" class="gmail_msg" target="_blank">swift-server-dev@swift.org</a><br class="gmail_msg"><a href="https://lists.swift.org/mailman/listinfo/swift-server-dev" class="gmail_msg" target="_blank">https://lists.swift.org/mailman/listinfo/swift-server-dev</a><br class="gmail_msg"></div></div></blockquote></div></div></div>_______________________________________________<br class="gmail_msg">
swift-server-dev mailing list<br class="gmail_msg">
<a href="mailto:swift-server-dev@swift.org" class="gmail_msg" target="_blank">swift-server-dev@swift.org</a><br class="gmail_msg">
<a href="https://lists.swift.org/mailman/listinfo/swift-server-dev" rel="noreferrer" class="gmail_msg" target="_blank">https://lists.swift.org/mailman/listinfo/swift-server-dev</a><br class="gmail_msg">
</blockquote></div>