[swift-server-dev] HTTP API Review

[Chris Bailey]

That does of course work as well - and may we'll be the preferred coding 
style. We should definitely document both approaches.

Chris



From:   Georgios Moschovitis <george.moschovitis at icloud.com>
To:     Chris Bailey <BAILEYC at uk.ibm.com>
Cc:     swift-server-dev at swift.org
Date:   04/09/2017 20:17
Subject:        Re: [swift-server-dev] HTTP API Review




How does the following look as a sample "Hello World" app? 

Looks much better to me. I would prefer the following though:


import HTTP

func handler(request: HTTPRequest, response: HTTPResponseWriter ) -> 
HTTPBodyProcessing { 
    response.writeHeader(status: .ok) 
    response.writeBody("Hello, World!") 
    response.done() 
    return .discardBody 
} 

try! HTTPServer().start(port: 8080, handler: handler)




import HTTP 

class MyServer: HTTPRequestHandling { 
    func handle(request: HTTPRequest, response: HTTPResponseWriter ) -> 
HTTPBodyProcessing { 
        response.writeHeader(status: .ok) 
        response.writeBody("Hello, World!") 
        response.done() 
        return .discardBody 
    } 
} 

let server = HTTPServer() 

try! server.start(port: 8080, handler: MyServer().handle) 


Chris 



From:        Georgios Moschovitis <george.moschovitis at icloud.com> 
To:        Chris Bailey <BAILEYC at uk.ibm.com> 
Cc:        swift-server-dev at swift.org 
Date:        03/09/2017 07:44 
Subject:        Re: [swift-server-dev] HTTP API Review 



Had a (very) quick look, and in general it looks OK. 
One thing that bothers me in the example is this ***Handler <-> 
***Handling inconsistency.. 

class SimpleHandler: HTTPRequestHandling 

maybe something like 

class WebApp: HTTPRequestHandling { 
  ... 
} 

would make it less confusing? 

-g. 



Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU



Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-server-dev/attachments/20170908/e7ad97d9/attachment.html>