<div><br><div class="gmail_quote"><div dir="auto">On Wed, Oct 4, 2017 at 10:57 AM Adrian Prantl <<a href="mailto:aprantl@apple.com">aprantl@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div><br><blockquote type="cite"><div>On Oct 4, 2017, at 10:54 AM, Saleem Abdulrasool <<a href="mailto:compnerd@compnerd.org" target="_blank">compnerd@compnerd.org</a>> wrote:</div><br class="m_1638133059612410291Apple-interchange-newline"><div><div><div dir="auto">Does the lldb test suite not run as part of the CI builds?</div></div></div></blockquote><div><br></div></div></div><div style="word-wrap:break-word;line-break:after-white-space"><div>AFAIK it is currently not running as part of pull request testing. (Which is obviously not ideal).</div><div></div></div><div style="word-wrap:break-word;line-break:after-white-space"><div></div></div></blockquote><div dir="auto"><br></div><div dir="auto">Getting some minimal coverage would be nice. But I think that would be outside of the scope of my changes. That can also be done subsequently to improve coverage.</div><div dir="auto"><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div><br><blockquote type="cite"><div><div><div dir="auto"><br></div><div dir="auto">It seems that in the mean time, at least two new regressions have been introduced into the Windows build. That does make me slightly hesistent since it seems that it is more likely that other regressions will get introduced.</div><div dir="auto"><br></div><div dir="auto">In any case, I’m doing a build of lldb and will look into this once the build completes. Hopefully the failures also reproduces on Linux.</div></div></div></blockquote><div><br></div></div></div><div style="word-wrap:break-word;line-break:after-white-space"><div>Thanks! Jim (<a href="mailto:jingham@apple.com" target="_blank">jingham@apple.com</a>) should be able to help you with any LLDB-related questions.</div><div></div></div></blockquote><div dir="auto"><br></div><div dir="auto">Awesome! I might have to take you up on that offer :)</div><div dir="auto"><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div><br></div><div></div></div><div style="word-wrap:break-word;line-break:after-white-space"><div>-- adrian</div></div><div style="word-wrap:break-word;line-break:after-white-space"><div><br><blockquote type="cite"><div><div><div dir="auto"><br></div><div dir="auto">Saleem</div><br><div class="gmail_quote"><div>On Wed, Oct 4, 2017 at 10:36 AM Adrian Prantl <<a href="mailto:aprantl@apple.com" target="_blank">aprantl@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div><br><blockquote type="cite"><div>On Oct 4, 2017, at 10:33 AM, Saleem Abdulrasool <<a href="mailto:compnerd@compnerd.org" target="_blank">compnerd@compnerd.org</a>> wrote:</div><br class="m_1638133059612410291m_2960310255281634466Apple-interchange-newline"><div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div class="gmail_quote"><div dir="auto"><br class="m_1638133059612410291m_2960310255281634466Apple-interchange-newline">On Wed, Oct 4, 2017 at 10:29 AM Jim Ingham <<a href="mailto:jingham@apple.com" target="_blank">jingham@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Nothing significant has changed on the lldb side but we're getting a bunch of tests asserting here:<br><br>21:01:25<br>Assertion failed: (isTypeMetadata()), function getDescription, file /Users/buildslave/jenkins/workspace/lldb-master-tools_RA/swift/include/swift/Runtime/Metadata.h, line 1469.<br><br>Anybody got any clues of what might have changed on the Swift side to start tripping this assertion?</blockquote><div dir="auto"><br></div><div dir="auto">The type metadata layout has changed. The value witness table reference is no longer an offset but rather a complete pointer.</div><div dir="auto"><br></div><div dir="auto">It is possible that lldb needs to be updated for that?</div></div></div></div></blockquote><div><br></div></div></div><div style="word-wrap:break-word;line-break:after-white-space"><div><div>That sounds plausible. Would it be possible to revert the commit until a solution is found? You can easily build lldb by checking it out next to swift and adding "-l" to the build script.</div></div></div><div style="word-wrap:break-word;line-break:after-white-space"><div><div><br></div><div>-- adrian</div></div></div><div style="word-wrap:break-word;line-break:after-white-space"><div><br><blockquote type="cite"><div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div class="gmail_quote"><div dir="auto"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><br>Jim<br><br><br><br>> On Oct 3, 2017, at 9:38 PM,<span class="m_1638133059612410291m_2960310255281634466Apple-converted-space"> </span><a href="mailto:no-reply@swift.org" target="_blank">no-reply@swift.org</a><span class="m_1638133059612410291m_2960310255281634466Apple-converted-space"> </span>wrote:<br>><br>> [FAILURE] oss-lldb-incremental-osx [#230]<br>><br>> Build URL: <span class="m_1638133059612410291m_2960310255281634466Apple-converted-space"> </span><a href="https://ci.swift.org/job/oss-lldb-incremental-osx/230/" rel="noreferrer" target="_blank">https://ci.swift.org/job/oss-lldb-incremental-osx/230/</a><br>> Project: oss-lldb-incremental-osx<br>> Date of build: Tue, 03 Oct 2017 22:55:41 -0500<br>> Build duration: 43 min<br>> Identified problems:<br>><br>> • Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:<br>> • Indication 1<br>> • Assertion failure: This build failed because of an assertion failure. Below is a list of all errors in the build log:<br>> • Indication 1<br>><br>> Changes<br>><br>> • Commit 99e395b7e3f89b1f6f2874296a37add58aece6d6 by github:<br>> [APINotes] Add 'RetainCountConvention' (#133)<br>><br>> • edit: include/clang/APINotes/Types.h<br>> • edit: lib/APINotes/APINotesWriter.cpp<br>> • edit: test/APINotes/Inputs/roundtrip.apinotes<br>> • edit: lib/APINotes/APINotesYAMLCompiler.cpp<br>> • edit: lib/APINotes/APINotesReader.cpp<br>> • add: test/APINotes/retain-count-convention.m<br>> • edit: test/APINotes/Inputs/Frameworks/SimpleKit.framework/Headers/SimpleKit.h<br>> • edit: lib/Sema/SemaAPINotes.cpp<br>> • edit: test/APINotes/yaml-roundtrip.c<br>> • edit: test/APINotes/Inputs/Frameworks/SimpleKit.framework/Headers/SimpleKit.apinotes<br>><br>> • Commit 969421f5ac164d98f4650ae0f1a4fd10409cabad by aprantl:<br>> [DebugInfo] Handle endianness when moving debug info for split integer<br>><br>> • edit: lib/CodeGen/SelectionDAG/LegalizeTypes.cpp<br>> • add: test/CodeGen/PowerPC/debuginfo-split-int.ll<br>><br>> • Commit e77f221279851c2406e824e75ae8904ba7d89ab5 by aprantl:<br>> Add a manpage for llvm-dwarfdump.<br>><br>> • edit: docs/CMakeLists.txt<br>> • edit: docs/CommandGuide/llvm-dwarfdump.rst<br>><br>> • Commit 2850e656c89ac7c4837a01b57c52c036e88c81f7 by jingham:<br>> This test is passing everywhere I can see, so I'm removing the xfail, to<br>><br>> • edit: packages/Python/lldbsuite/test/functionalities/thread/exit_during_step/TestExitDuringStep.py<br>><br>> • Commit 7e6b564bf551e1ccd4eaff2824d87dd89b71a686 by dgregor:<br>> Add fixed crasher from <a>rdar://problem/33575781</a><br>><br>> • add: validation-test/compiler_crashers_2_fixed/0125-rdar33575781.swift<br>><br>> • Commit 086c12114dfdff1b7b7179a6052f43a8d73557ed by compnerd:<br>> IRGen: switch to absolute pointers for nominal type descriptors<br>><br>> • edit: include/swift/Runtime/Metadata.h<br>> • edit: lib/IRGen/ConstantBuilder.h<br>> • edit: stdlib/public/runtime/Metadata.cpp<br>> • edit: unittests/runtime/Metadata.cpp<br>> • edit: lib/IRGen/GenMeta.cpp<br>> • edit: stdlib/public/runtime/ProtocolConformance.cpp<br>> • edit: test/IRGen/foreign_types.sil<br>> • edit: test/IRGen/objc_attr_NSManaged.sil<br>> • edit: include/swift/Remote/MetadataReader.h<br>> • edit: stdlib/public/runtime/Casting.cpp<br>> • edit: test/IRGen/field_type_vectors.sil<br>><br>> • Commit 2645a6a4b9cf2df212da6db9a41b3363ff44de56 by dgregor:<br>> [Deserialization] Configure protocol before loading requirement<br>><br>> • add: test/Serialization/recursive_protocol_merge.swift<br>> • add: test/Serialization/Inputs/recursive_protocol_merge_b.swift<br>> • add: test/Serialization/Inputs/recursive_protocol_merge_a.swift<br>> • edit: lib/Serialization/Deserialization.cpp<br>><br>> • Commit 610aa582ce9647ad377812355d8ae36ec5cf0e31 by shajrawi:<br>> Fixes (another) IRGen compiler crash caused by the new large types ABI<br>><br>> • edit: test/IRGen/big_types_corner_cases.sil<br>> • edit: lib/IRGen/LoadableByAddress.cpp<br>><br>> • Commit 77554c1ae2b3b2de16b803409d9f7085ad186562 by ghoare:<br>> [Stats] Fix typo.<br>><br>> • edit: lib/Basic/Statistic.cpp<br>><br>> • Commit 0e5b982d2561bc7c102e2abe984e19241735aaa2 by ghoare:<br>> [Stats] Only use input filename, not mangled path, in stats file name.<br>><br>> • edit: lib/Basic/Statistic.cpp<br>><br>> • Commit c1a4bb490bcdf8d20c962ab43249eaee44ee037f by github:<br>> [test] Define out part of this test that's crashing on Linux (#12258)<br>><br>> • edit: test/ClangImporter/clang_builtins.swift<br><br></blockquote></div></div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">--<span class="m_1638133059612410291m_2960310255281634466Apple-converted-space"> </span><br></div><div class="m_1638133059612410291m_2960310255281634466gmail_signature" data-smartmail="gmail_signature" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div></div></blockquote></div></div></blockquote></div></div><div>-- <br></div><div class="m_1638133059612410291gmail_signature" data-smartmail="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</div></blockquote></div></div></blockquote></div></div><div dir="ltr">-- <br></div><div class="gmail_signature" data-smartmail="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>