<div dir="ltr">+Mishal, while Ryan et al are looking at the broken REPL, would it make sense to update the CI servers with the Python pexpect module so that the test-repl-glibc.py will fail the build?<div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Apr 15, 2016 at 10:19 AM, Ryan Lovelett <span dir="ltr"><<a href="mailto:swift-dev@ryan.lovelett.me" target="_blank">swift-dev@ryan.lovelett.me</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I've tried reverting c6121d56b19305cf59148d46af54c06b771f3180 just to<br>
see if doing that will restore functionality to lldb/repl.<br>
<br>
Unfortunately too many things have changed in the build system since<br>
that commit for a revert to make sense anymore.<br>
<br>
Can anyone provide documentation/explain the mechanics of what happens<br>
when I type "import Glibc" into the REPL/lldb?<br>
<div><div><br>
On Thu, Apr 14, 2016, at 05:47 PM, Dmitri Gribenko wrote:<br>
> +Brian<br>
><br>
> On Thu, Apr 14, 2016 at 2:46 PM, Ryan Lovelett via swift-dev<br>
> <<a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a>> wrote:<br>
> > I've played around with `git bisect` and I think I've tracked it down to<br>
> > this commit [1]. Which came from PR #1704 [2]. I've also updated the issue,<br>
> > SR-1109, to include this information.<br>
> ><br>
> > c6121d56b19305cf59148d46af54c06b771f3180 is the first bad commit<br>
> > commit c6121d56b19305cf59148d46af54c06b771f3180<br>
> > Author: Brian Gesiak <<a href="mailto:bgesiak@fb.com" target="_blank">bgesiak@fb.com</a>><br>
> > Date: Wed Mar 16 13:29:42 2016 -0400<br>
> ><br>
> > [Un-revert][Glibc] Configure modulemap for target, not host<br>
> ><br>
> > This reverts commit f2154ee94d, which reverted 04e1cd5bda. The original<br>
> > commit needed to be reverted because of an issue in which install<br>
> > targets were added to OS X builds that did not target Linux. This<br>
> > addresses that issue by guarding all the Linux-only CMake logic with a<br>
> > check for the SDK being built.<br>
> ><br>
> > :040000 040000 e92829c16aa22f20edfdf95f3bb18bb15a3fa226<br>
> > 90062ad44050a19fc0d5bc846409945e83619b01 M lib<br>
> > :040000 040000 bbe94bf4af832e154065bc0bcafffab2dacb839e<br>
> > 1a8be73f86884bda848cde22885bcd72a17660b2 M stdlib<br>
> > :040000 040000 abf55068f67ee44e2bd52169aa8b988fb8aead28<br>
> > 41db0f8ddec3281f51c6798dd47c86675b7118b3 M tools<br>
> ><br>
> > [1]<br>
> > <a href="https://github.com/apple/swift/commit/c6121d56b19305cf59148d46af54c06b771f3180" rel="noreferrer" target="_blank">https://github.com/apple/swift/commit/c6121d56b19305cf59148d46af54c06b771f3180</a><br>
> > [2] <a href="https://github.com/apple/swift/pull/1704" rel="noreferrer" target="_blank">https://github.com/apple/swift/pull/1704</a><br>
> ><br>
> ><br>
> > On Thu, Apr 14, 2016, at 12:36 PM, Jordan Rose wrote:<br>
> ><br>
> > +swift-lldb-dev<br>
> ><br>
> ><br>
> > On Apr 14, 2016, at 7:20 , Joseph Bell via swift-dev <<a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a>><br>
> > wrote:<br>
> ><br>
> > Ryan, thanks. I've voted on SR-1109 and will add the steps I use to<br>
> > reproduce as well.<br>
> ><br>
> > I think now its clear why the 14.04 and 15.10 packaging tests are passing,<br>
> > and that's because they aren't running the tests that leverage pexpect, if<br>
> > you look at the console log for the 14.04 test:<br>
> > <a href="https://ci.swift.org/view/Packages/job/oss-swift-package-linux-ubuntu-14_04/993/consoleText" rel="noreferrer" target="_blank">https://ci.swift.org/view/Packages/job/oss-swift-package-linux-ubuntu-14_04/993/consoleText</a><br>
> ><br>
> > lit.py: lit.cfg:101: note: 'pexpect' module unavailable, skipping related<br>
> > tests<br>
> ><br>
> > Perhaps pexpect should be added to the CI server so these tests can begin<br>
> > failing properly.<br>
> ><br>
> ><br>
> > On Thu, Apr 14, 2016 at 8:47 AM, Ryan Lovelett via swift-dev<br>
> > <<a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a>> wrote:<br>
> ><br>
> ><br>
> ><br>
> > On Thu, Apr 14, 2016, at 09:17 AM, Joseph Bell via swift-dev wrote:<br>
> ><br>
> > Howdy,<br>
> ><br>
> > I've mentioned this once before and didn't get any feedback; I thought I'd<br>
> > give it one more shot.<br>
> ><br>
> > Has anyone out there tried building, from scratch, the Swift 3.0 package on<br>
> > Ubuntu? The compile, link, packaging steps all complete successfully, but<br>
> > then the repl/test-repl-glibc.py fails. The failure is that the REPL<br>
> > doesn't interact (the underlying script is using pexpect to send/expect)<br>
> > properly:<br>
> ><br>
> > 2> import Glibc<br>
> > warning: <REPL>:1:1: warning: #line directive is deprecated, please use<br>
> > #sourceLocation instead<br>
> > #line 2 "repl.swift"<br>
> > ^~~~~<br>
> > #sourceLocation<br>
> ><br>
> > warning: repl.swift:3:1: warning: #line directive is deprecated, please use<br>
> > #sourceLocation instead<br>
> > #line<br>
> > ^~~~~<br>
> > #sourceLocation<br>
> ><br>
> > error: repl.swift:2:8: error: missing required module 'SwiftGlibc'<br>
> > import Glibc<br>
> ><br>
> > This is occurring on two separate Ubuntu 14.04 systems, one of which is a<br>
> > greenfield VM with all of the prerequisites/clang-3.6 installed.<br>
> ><br>
> > Stumped on this one and was just curious if anyone can reproduce.<br>
> ><br>
> ><br>
> ><br>
> > I can also reproduce. I actually broght this up yesterday too (just on a<br>
> > different list) [1]. I suggest you go vote for SR-1109 [2] which is the bug<br>
> > report for this issue.<br>
> ><br>
> > I think this is show stopper. Not for the REPL break but because it also<br>
> > breaks the debugger on Linux as well.<br>
> ><br>
> > Right now I'm trying to bisect the repos to see which commit(s?) might have<br>
> > introduced this regression. Kate Stone mentioned that she thinks this issue<br>
> > was introduced sometime after the 3-16 snapshot. I'm trying to corroborate<br>
> > that.<br>
> ><br>
> > [1]<br>
> > <a href="https://lists.swift.org/pipermail/swift-lldb-dev/Week-of-Mon-20160411/000106.html" rel="noreferrer" target="_blank">https://lists.swift.org/pipermail/swift-lldb-dev/Week-of-Mon-20160411/000106.html</a><br>
> > [2] <a href="https://bugs.swift.org/browse/SR-1109" rel="noreferrer" target="_blank">https://bugs.swift.org/browse/SR-1109</a><br>
> ><br>
> ><br>
> ><br>
> ><br>
> > Thanks,<br>
> > Joe<br>
> ><br>
> ><br>
> ><br>
> > ---<br>
> > <a href="http://dev.iachieved.it/iachievedit/" rel="noreferrer" target="_blank">http://dev.iachieved.it/iachievedit/</a><br>
> > @iachievedit<br>
> ><br>
> > _______________________________________________<br>
> > swift-dev mailing list<br>
> > <a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a><br>
> > <a href="https://lists.swift.org/mailman/listinfo/swift-dev" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-dev</a><br>
> ><br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > swift-dev mailing list<br>
> > <a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a><br>
> > <a href="https://lists.swift.org/mailman/listinfo/swift-dev" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-dev</a><br>
> ><br>
> ><br>
> ><br>
> ><br>
> ><br>
> > --<br>
> > ---<br>
> > <a href="http://dev.iachieved.it/iachievedit/" rel="noreferrer" target="_blank">http://dev.iachieved.it/iachievedit/</a><br>
> > @iachievedit<br>
> > _______________________________________________<br>
> > swift-dev mailing list<br>
> > <a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a><br>
> > <a href="https://lists.swift.org/mailman/listinfo/swift-dev" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-dev</a><br>
> ><br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > swift-dev mailing list<br>
> > <a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a><br>
> > <a href="https://lists.swift.org/mailman/listinfo/swift-dev" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-dev</a><br>
> ><br>
><br>
><br>
><br>
> --<br>
> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if<br>
> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>>*/<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr">---<div><a href="http://dev.iachieved.it/iachievedit/" target="_blank">http://dev.iachieved.it/iachievedit/</a></div><div>@iachievedit</div></div></div>
</div></div></div>