<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">“New issue” script looks at Identified problems and compares them with last build,&nbsp;xUnit plug-in can only handle test failures.<div class=""><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 3, 2016, at 2:42 PM, Todd Fiala &lt;<a href="mailto:tfiala@apple.com" class="">tfiala@apple.com</a>&gt; wrote:</div><br class="Apple-interchange-newline"><div class=""><blockquote type="cite" class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class=""><br class="Apple-interchange-newline">On Mar 3, 2016, at 2:41 PM, Todd Fiala via swift-lldb-dev &lt;<a href="mailto:swift-lldb-dev@swift.org" class="">swift-lldb-dev@swift.org</a>&gt; wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Mar 3, 2016, at 2:37 PM, Mishal Shah &lt;<a href="mailto:mishal_shah@apple.com" class="">mishal_shah@apple.com</a>&gt; wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Ben and I had a chat about this, its due to how lldb test suite prints to console. I will need to update the “New issue” script to handle this better.&nbsp;</div></div></blockquote><div class=""><br class=""></div><div class=""><br class=""></div><div class="">Ideally it is just pulling info from the xUnit results and working off of that?</div><br class=""></div></div></div></blockquote><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class=""></div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">(Like, can’t the Jenkins xUnit plug-in already do this?)</div><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><blockquote type="cite" class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div class=""><blockquote type="cite" class=""><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div class=""><br class=""></div><div class="">Thanks,&nbsp;</div><div class="">Mishal Shah&nbsp;<div class=""><br class=""></div><div class=""><div class=""><blockquote type="cite" class=""><div class="">On Mar 3, 2016, at 2:34 PM, Todd Fiala &lt;<a href="mailto:tfiala@apple.com" class="">tfiala@apple.com</a>&gt; wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Ah I see the distinction you are making.<div class=""><br class=""></div><div class="">Thanks for clarifying. &nbsp;(Mishal, that would be great to distinguish here).</div><div class=""><br class=""></div><div class="">-Todd</div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Mar 3, 2016, at 2:33 PM, Ben Langmuir &lt;<a href="mailto:blangmuir@apple.com" class="">blangmuir@apple.com</a>&gt; wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">My point is they aren’t “new issues” in each commit, so we shouldn’t get emailed. &nbsp;We have a script that checks if the issue is new, but that script doesn’t take into account that the test order may be inconsistent.<div class=""><br class=""></div><div class="">Ben<br class=""><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Mar 3, 2016, at 2:32 PM, Todd Fiala &lt;<a href="mailto:tfiala@apple.com" class="">tfiala@apple.com</a>&gt; wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">These are real failures. &nbsp;They are due to a Swift change that is emitting invalid symbols. &nbsp;Lang/Roman are working on a fix. &nbsp;I didn’t mark these as failures because they are working on the fix.<div class=""><br class=""></div><div class="">If we wanted to limit noise, the right thing to do here would have been to revert that change until they could work out the bad symbol names reported by the JIT. &nbsp;(I was okay with not insisting on that because they were going to quickly track this down).</div><div class=""><br class=""></div><div class="">-Todd</div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Mar 3, 2016, at 1:31 PM, Ben Langmuir via swift-lldb-dev &lt;<a href="mailto:swift-lldb-dev@swift.org" class="">swift-lldb-dev@swift.org</a>&gt; wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">This is the same old failure we’ve been seeing for a while. &nbsp;I filed a radar to improve the “new issue” detection so it won’t send all these false positives for lldb tests:<div class="">&lt;<a href="rdar://problem/24961012" class="">rdar://problem/24961012</a>&gt; Don't report "new issue" when test failures happen in different orders</div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">Ben</div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Mar 3, 2016, at 1:20 PM,<span class="Apple-converted-space">&nbsp;</span><a href="mailto:no-reply@swift.org" class="">no-reply@swift.org</a><span class="Apple-converted-space">&nbsp;</span>wrote:</div><br class="Apple-interchange-newline"><div class=""><table class="" style="font-family: 'Helvetica Neue', sans-serif; letter-spacing: normal; orphans: auto; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><tbody class=""><tr class="" style="text-align: left;"><td class=""><a href="https://ci.swift.org/job/oss-lldb-incremental-linux-ubuntu-14_04/1915/" class="" style="color: rgb(0, 122, 255); text-decoration: none;"><br class="Apple-interchange-newline">https://ci.swift.org/job/oss-lldb-incremental-linux-ubuntu-14_04/1915/</a></td></tr></tbody></table></div></blockquote></div><br class=""></div></div>_______________________________________________<br class="">swift-lldb-dev mailing list<br class=""><a href="mailto:swift-lldb-dev@swift.org" class="">swift-lldb-dev@swift.org</a><br class=""><a href="https://lists.swift.org/mailman/listinfo/swift-lldb-dev" class="">https://lists.swift.org/mailman/listinfo/swift-lldb-dev</a><br class=""></div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></div></div></div></div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></div></div></div></div></blockquote></div><br class=""></div>_______________________________________________<br class="">swift-lldb-dev mailing list<br class=""><a href="mailto:swift-lldb-dev@swift.org" class="">swift-lldb-dev@swift.org</a><br class=""><a href="https://lists.swift.org/mailman/listinfo/swift-lldb-dev" class="">https://lists.swift.org/mailman/listinfo/swift-lldb-dev</a></div></blockquote></div></blockquote></div><br class=""></div></div></body></html>