<div dir="ltr">Thanks! <div><br></div><div>Complete command: </div><div><br></div><div><pre class="" style="white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(0,0,0);font-size:11px">swift/utils/build-script --preset=buildbot_osx_package install_destdir=/tmp/swift-install installable_package=/tmp/swift.tar.gz install_toolchain_dir=/Applications/Xcode.app/Contents/Developer/Toolchains/swift.xctoolchain install_symroot=/tmp/swift-symroot symbols_package=/tmp/swift-symbols.tar.gz darwin_toolchain_bundle_identifier=com.test.x 'darwin_toolchain_display_name=test' darwin_toolchain_xctoolchain_name=swift darwin_toolchain_version=swift</pre><pre class="" style="white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(0,0,0);font-size:11px"><br></pre></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature">Mishal Shah</div></div>
<br><div class="gmail_quote">On Thu, Dec 3, 2015 at 11:01 PM, Todd Fiala <span dir="ltr"><<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Sure thing, sorry for the bother.</div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Thu, Dec 3, 2015 at 11:00 PM, Dmitri Gribenko <span dir="ltr"><<a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks, Todd!<br>
<div><div><br>
On Thu, Dec 3, 2015 at 11:00 PM, Todd Fiala <<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>> wrote:<br>
> Mishal,<br>
><br>
> Reverted here:<br>
><br>
> commit 02a493b8380bbcb5c4bf2e123db0b6d79c95dc8f (HEAD -> master,<br>
> origin/master, origin/HEAD)<br>
> Author: Todd Fiala <<a href="mailto:tfiala@apple.com" target="_blank">tfiala@apple.com</a>><br>
> Date: Thu Dec 3 22:57:16 2015<br>
><br>
><br>
> You should be back in business.<br>
><br>
> I'll re-introduce this change a more appropriate way in the morning.<br>
><br>
> -Todd<br>
><br>
><br>
> On Thu, Dec 3, 2015 at 10:56 PM, Todd Fiala <<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>> wrote:<br>
>><br>
>> Okay I think I see the issue. It is that we can still pass backdoor<br>
>> combinations of build modes after the '--' in build-script that will control<br>
>> the final build variant used by lldb.<br>
>><br>
>> The logic for this check doesn't belong in build-script, but rather<br>
>> build-script-impl. build-script-impl is the only place to find the final<br>
>> build mode after considering both the values passed to build-script, and<br>
>> other bits that can be passed along to build-script-impl.<br>
>><br>
>> I'm going to revert my change and add a proper fix in the morning. I<br>
>> don't have enough brain power to do it right and test it now.<br>
>><br>
>> On Thu, Dec 3, 2015 at 10:51 PM, Todd Fiala <<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>> wrote:<br>
>>><br>
>>> Yep I finally added enough gunk to the command line to reproduce.<br>
>>><br>
>>> I'm looking at how it's getting the Release value now. That's the issue<br>
>>> (I'm not seeing it come in as Release).<br>
>>><br>
>>> On Thu, Dec 3, 2015 at 10:44 PM, Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>><br>
>>> wrote:<br>
>>>><br>
>>>> On Thu, Dec 3, 2015 at 10:41 PM, Todd Fiala <<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>><br>
>>>> wrote:<br>
>>>> > I see.<br>
>>>> ><br>
>>>> > And I think I see the issue. It's trying to do a release-debuginfo<br>
>>>> > build<br>
>>>> > across the board. LLDB chokes on those. So we'll need to explicitly<br>
>>>> > set<br>
>>>> > the lldb build variant to something different (either release or<br>
>>>> > debug,<br>
>>>> > likely release).<br>
>>>><br>
>>>> The preset is trying to do that (lldb-build-type=Release), but<br>
>>>> apparently is getting ignored.<br>
>>>><br>
>>>> Dmitri<br>
>>>><br>
>>>> --<br>
>>>> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if<br>
>>>> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>>*/<br>
>>><br>
>>><br>
>>><br>
>>><br>
>>> --<br>
>>> -Todd<br>
>><br>
>><br>
>><br>
>><br>
>> --<br>
>> -Todd<br>
><br>
><br>
><br>
><br>
> --<br>
> -Todd<br>
<br>
<br>
<br>
--<br>
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if<br>
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>>*/<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div><div dir="ltr">-Todd</div></div>
</font></span></div>
</blockquote></div><br></div>