<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Okay cool. I’ll use that later today when I work on the original task in a way that doesn’t break this usage.<div class=""><br class=""></div><div class="">-Todd</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 4, 2015, at 12:09 AM, Mishal Shah <<a href="mailto:shahmishal@gmail.com" class="">shahmishal@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Thanks! <div class=""><br class=""></div><div class="">Complete command: </div><div class=""><br class=""></div><div class=""><pre class="" style="white-space: pre-wrap; word-wrap: break-word; margin-top: 0px; margin-bottom: 0px; font-size: 11px;">swift/utils/build-script --preset=buildbot_osx_package install_destdir=/tmp/swift-install installable_package=/tmp/swift.tar.gz install_toolchain_dir=/Applications/Xcode.app/Contents/Developer/Toolchains/swift.xctoolchain install_symroot=/tmp/swift-symroot symbols_package=/tmp/swift-symbols.tar.gz darwin_toolchain_bundle_identifier=com.test.x 'darwin_toolchain_display_name=test' darwin_toolchain_xctoolchain_name=swift darwin_toolchain_version=swift</pre><pre class="" style="white-space: pre-wrap; word-wrap: break-word; margin-top: 0px; margin-bottom: 0px; font-size: 11px;"><br class=""></pre></div></div><div class="gmail_extra"><br clear="all" class=""><div class=""><div class="gmail_signature">Mishal Shah</div></div>
<br class=""><div class="gmail_quote">On Thu, Dec 3, 2015 at 11:01 PM, Todd Fiala <span dir="ltr" class=""><<a href="mailto:todd.fiala@gmail.com" target="_blank" class="">todd.fiala@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">Sure thing, sorry for the bother.</div><div class="gmail_extra"><div class=""><div class="h5"><br class=""><div class="gmail_quote">On Thu, Dec 3, 2015 at 11:00 PM, Dmitri Gribenko <span dir="ltr" class=""><<a href="mailto:gribozavr@gmail.com" target="_blank" class="">gribozavr@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks, Todd!<br class="">
<div class=""><div class=""><br class="">
On Thu, Dec 3, 2015 at 11:00 PM, Todd Fiala <<a href="mailto:todd.fiala@gmail.com" target="_blank" class="">todd.fiala@gmail.com</a>> wrote:<br class="">
> Mishal,<br class="">
><br class="">
> Reverted here:<br class="">
><br class="">
> commit 02a493b8380bbcb5c4bf2e123db0b6d79c95dc8f (HEAD -> master,<br class="">
> origin/master, origin/HEAD)<br class="">
> Author: Todd Fiala <<a href="mailto:tfiala@apple.com" target="_blank" class="">tfiala@apple.com</a>><br class="">
> Date: Thu Dec 3 22:57:16 2015<br class="">
><br class="">
><br class="">
> You should be back in business.<br class="">
><br class="">
> I'll re-introduce this change a more appropriate way in the morning.<br class="">
><br class="">
> -Todd<br class="">
><br class="">
><br class="">
> On Thu, Dec 3, 2015 at 10:56 PM, Todd Fiala <<a href="mailto:todd.fiala@gmail.com" target="_blank" class="">todd.fiala@gmail.com</a>> wrote:<br class="">
>><br class="">
>> Okay I think I see the issue. It is that we can still pass backdoor<br class="">
>> combinations of build modes after the '--' in build-script that will control<br class="">
>> the final build variant used by lldb.<br class="">
>><br class="">
>> The logic for this check doesn't belong in build-script, but rather<br class="">
>> build-script-impl. build-script-impl is the only place to find the final<br class="">
>> build mode after considering both the values passed to build-script, and<br class="">
>> other bits that can be passed along to build-script-impl.<br class="">
>><br class="">
>> I'm going to revert my change and add a proper fix in the morning. I<br class="">
>> don't have enough brain power to do it right and test it now.<br class="">
>><br class="">
>> On Thu, Dec 3, 2015 at 10:51 PM, Todd Fiala <<a href="mailto:todd.fiala@gmail.com" target="_blank" class="">todd.fiala@gmail.com</a>> wrote:<br class="">
>>><br class="">
>>> Yep I finally added enough gunk to the command line to reproduce.<br class="">
>>><br class="">
>>> I'm looking at how it's getting the Release value now. That's the issue<br class="">
>>> (I'm not seeing it come in as Release).<br class="">
>>><br class="">
>>> On Thu, Dec 3, 2015 at 10:44 PM, Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com" target="_blank" class="">gribozavr@gmail.com</a>><br class="">
>>> wrote:<br class="">
>>>><br class="">
>>>> On Thu, Dec 3, 2015 at 10:41 PM, Todd Fiala <<a href="mailto:todd.fiala@gmail.com" target="_blank" class="">todd.fiala@gmail.com</a>><br class="">
>>>> wrote:<br class="">
>>>> > I see.<br class="">
>>>> ><br class="">
>>>> > And I think I see the issue. It's trying to do a release-debuginfo<br class="">
>>>> > build<br class="">
>>>> > across the board. LLDB chokes on those. So we'll need to explicitly<br class="">
>>>> > set<br class="">
>>>> > the lldb build variant to something different (either release or<br class="">
>>>> > debug,<br class="">
>>>> > likely release).<br class="">
>>>><br class="">
>>>> The preset is trying to do that (lldb-build-type=Release), but<br class="">
>>>> apparently is getting ignored.<br class="">
>>>><br class="">
>>>> Dmitri<br class="">
>>>><br class="">
>>>> --<br class="">
>>>> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if<br class="">
>>>> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com" target="_blank" class="">gribozavr@gmail.com</a>>*/<br class="">
>>><br class="">
>>><br class="">
>>><br class="">
>>><br class="">
>>> --<br class="">
>>> -Todd<br class="">
>><br class="">
>><br class="">
>><br class="">
>><br class="">
>> --<br class="">
>> -Todd<br class="">
><br class="">
><br class="">
><br class="">
><br class="">
> --<br class="">
> -Todd<br class="">
<br class="">
<br class="">
<br class="">
--<br class="">
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if<br class="">
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com" target="_blank" class="">gribozavr@gmail.com</a>>*/<br class="">
</div></div></blockquote></div><br class=""><br clear="all" class=""><div class=""><br class=""></div></div></div><span class="HOEnZb"><font color="#888888" class="">-- <br class=""><div class=""><div dir="ltr" class="">-Todd</div></div>
</font></span></div>
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>