<div dir="ltr">Oops looks like I lost you on the To line, Mishal. See thread.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 3, 2015 at 11:00 PM, Todd Fiala <span dir="ltr"><<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Mishal,<div><br></div><div>Reverted here:</div><div><br></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div><div>commit 02a493b8380bbcb5c4bf2e123db0b6d79c95dc8f (HEAD -> master, origin/master, origin/HEAD)</div></div><div><div>Author: Todd Fiala <<a href="mailto:tfiala@apple.com" target="_blank">tfiala@apple.com</a>></div></div><div><div>Date: Thu Dec 3 22:57:16 2015</div></div></blockquote><div><br></div><div>You should be back in business.</div><div><br></div><div>I'll re-introduce this change a more appropriate way in the morning.</div><div><br></div><div>-Todd</div><div><br></div></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Thu, Dec 3, 2015 at 10:56 PM, Todd Fiala <span dir="ltr"><<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Okay I think I see the issue. It is that we can still pass backdoor combinations of build modes after the '--' in build-script that will control the final build variant used by lldb.<div><br></div><div>The logic for this check doesn't belong in build-script, but rather build-script-impl. build-script-impl is the only place to find the final build mode after considering both the values passed to build-script, and other bits that can be passed along to build-script-impl.</div><div><br></div><div>I'm going to revert my change and add a proper fix in the morning. I don't have enough brain power to do it right and test it now.</div></div><div class="gmail_extra"><div><div><br><div class="gmail_quote">On Thu, Dec 3, 2015 at 10:51 PM, Todd Fiala <span dir="ltr"><<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Yep I finally added enough gunk to the command line to reproduce.<div><br></div><div>I'm looking at how it's getting the Release value now. That's the issue (I'm not seeing it come in as Release).</div></div><div class="gmail_extra"><div><div><br><div class="gmail_quote">On Thu, Dec 3, 2015 at 10:44 PM, Dmitri Gribenko <span dir="ltr"><<a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On Thu, Dec 3, 2015 at 10:41 PM, Todd Fiala <<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>> wrote:<br>
> I see.<br>
><br>
> And I think I see the issue. It's trying to do a release-debuginfo build<br>
> across the board. LLDB chokes on those. So we'll need to explicitly set<br>
> the lldb build variant to something different (either release or debug,<br>
> likely release).<br>
<br>
</span>The preset is trying to do that (lldb-build-type=Release), but<br>
apparently is getting ignored.<br>
<div><div><br>
Dmitri<br>
<br>
--<br>
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if<br>
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>>*/<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br><div><div dir="ltr">-Todd</div></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br><div><div dir="ltr">-Todd</div></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div><div dir="ltr">-Todd</div></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">-Todd</div></div>
</div>