<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">On Dec 30, 2017, at 3:12 PM, Jacob Bandes-Storch via swift-evolution <<a href="mailto:swift-evolution@swift.org" class="">swift-evolution@swift.org</a>> wrote:<br class=""><div><blockquote type="cite" class="">Sorry for the delay. I've just updated the proposal text to incorporate various changes, some contributed by others.<br class=""><div class=""><div dir="ltr" class=""><div class=""><br class=""></div><a href="https://github.com/jtbandes/swift-evolution/blob/case-enumerable/proposals/0000-derived-collection-of-enum-cases.md" class="">https://github.com/jtbandes/swift-evolution/blob/case-enumerable/proposals/0000-derived-collection-of-enum-cases.md</a></div></div></blockquote><div><br class=""></div><div>I would really love to see this happen. I did a pass over the proposal, I strong suggest that you get Joe Groff’s input on this, because he has some opinions as well.</div><div><br class=""></div><div>IMO, the proposal looks really great except for one thing: In "proposed solution”, I think it is very important that conformance to ValueEnumerable be explicitly requested in the code. Specifically:</div><div><br class=""></div><div>enum Ma { case 马, 吗, 妈, 码, 骂, 麻, 🐎, 🐴 }<br class="">Ma.allValues // error.</div><div><br class=""></div><div><div>enum Ma : ValueEnumerable { case 马, 吗, 妈, 码, 骂, 麻, 🐎, 🐴 }<br class="">Ma.allValues // works!</div><div class=""><br class=""></div><br class=""></div><div>This is for two reasons:</div><div>1) Consistency with other similar features in Swift. Types are not hashable just because their members could be. This is because we want people to think about and explicitly opt into API features like this.</div><div>2) To align with our resilience design. An enum with no value-associated cases today could acquire them in the future, and doing so would implicitly remove this conformance. This would be surprising and bad.</div><div><br class=""></div><div>Thanks for pushing this forward!</div><div><br class=""></div><div>-Chris</div><div><br class=""></div><div><br class=""></div><div><br class=""></div><div><br class=""></div><br class=""><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class="">Robert's <a href="https://github.com/apple/swift-evolution/pull/114#issuecomment-337105126" class="">implementation</a> is a good start, but will need to be updated to match the naming choice in the final proposal, and to use associatedtype.<div class=""><div class="gmail_extra">
<br class=""><div class="gmail_quote">On Fri, Dec 8, 2017 at 9:19 PM, Step Christopher <span dir="ltr" class=""><<a href="mailto:schristopher@bignerdranch.com" target="_blank" class="">schristopher@bignerdranch.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto" class=""><div class=""></div><div class="">Has this stalled out again? I would like to help with the proposal and even attempt implementation. </div><div class=""><br class=""></div><div class="">I also need to catch up on the resilient discussion regarding enum case ordering. </div><div class=""><div class="h5"><div class=""><br class="">On Nov 14, 2017, at 10:50 PM, Jacob Bandes-Storch via swift-evolution <<a href="mailto:swift-evolution@swift.org" target="_blank" class="">swift-evolution@swift.org</a>> wrote:<br class=""><br class=""></div><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br clear="all" class=""><div class=""><div class="m_6284411688378109394gmail_signature" data-smartmail="gmail_signature"><div dir="ltr" class=""><div class="">Jacob Bandes-Storch<br class=""></div></div></div></div>
<br class=""><div class="gmail_quote">On Tue, Nov 14, 2017 at 9:06 PM, Brent Royal-Gordon <span dir="ltr" class=""><<a href="mailto:brent@architechies.com" target="_blank" class="">brent@architechies.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space" class=""><div class=""><span class=""><blockquote type="cite" class=""><div class="">On Nov 14, 2017, at 5:21 PM, Xiaodi Wu <<a href="mailto:xiaodi.wu@gmail.com" target="_blank" class="">xiaodi.wu@gmail.com</a>> wrote:</div><br class="m_6284411688378109394m_40430440677206812Apple-interchange-newline"><div class=""><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space" class=""><div class="">1. It must be possible to easily access the count of values, and to access any particular value using contiguous `Int` indices. This could be achieved either by directly accessing elements in the list of values through an Int subscript, or by constructing an Array from the list of values.</div><div class=""><br class=""></div><div class="">2. It must be possible to control the order of values in the list of values, either by using source order or through some other simple, straightforward mechanism.</div></div></blockquote><div class=""> </div><div class="">OK, first of all, nowhere in the proposal text are these requirements stated as part of the use case. You're free to put forward new use cases, but here I am trying to design the most elegant way to fulfill a stated need and you're telling me that it's something other than what's written.</div></div></div></div></div></blockquote><div class=""><br class=""></div></span><div class="">Honestly, re-reading the proposal, it never cites a fully-formed use case. Instead, it cites several blog posts, Stack Overflow questions, and small code samples without digging in to the underlying reasons why developers are doing what they're doing. Most of the people discussing it so far seem to have had a tacit understanding that we wanted roughly Array-like access, but we haven't explicitly dug into which properties of an Array are important.</div><div class=""><br class=""></div><div class="">(If anyone involved feels like they had a different understanding of the use case, please speak up.)</div><div class=""><br class=""></div><div class="">I think this is a place where the proposal can be improved, and I'm willing to do some writing to improve it.</div></div></div></blockquote><div class=""><br class=""></div><div class="">For the record, I would be happy to add co-authors (or even relinquish authorship entirely—I don't really care whose name is on this, it just needs to happen!) if you or anyone else has improved wording, motivation, justification, etc. to contribute.</div></div></div></div>
</div></blockquote></div></div><blockquote type="cite" class=""><div class=""><span class="">______________________________<wbr class="">_________________</span><span class=""><br class=""><span class="">swift-evolution mailing list</span><br class=""><span class=""><a href="mailto:swift-evolution@swift.org" target="_blank" class="">swift-evolution@swift.org</a></span><br class=""><span class=""><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" target="_blank" class="">https://lists.swift.org/<wbr class="">mailman/listinfo/swift-<wbr class="">evolution</a></span><br class=""></span></div></blockquote></div></blockquote></div><br class=""></div></div></div>
_______________________________________________<br class="">swift-evolution mailing list<br class=""><a href="mailto:swift-evolution@swift.org" class="">swift-evolution@swift.org</a><br class="">https://lists.swift.org/mailman/listinfo/swift-evolution<br class=""></div></blockquote></div><br class=""></body></html>