<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><span style="background-color: rgba(255, 255, 255, 0);">Proposal link:</span><span style="background-color: rgba(255, 255, 255, 0);"> </span><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0193-cross-module-inlining-and-specialization.md" dir="ltr" x-apple-data-detectors="true" x-apple-data-detectors-type="link" x-apple-data-detectors-result="5" style="background-color: rgba(255, 255, 255, 0);">https://github.com/apple/swift-evolution/blob/master/proposals/0193-cross-module-inlining-and-specialization.md</a><br><ul style="-webkit-print-color-adjust: exact; margin: 15px 0px; padding-left: 30px;"><li style="-webkit-print-color-adjust: exact; margin: 0px;"><p style="-webkit-print-color-adjust: exact; margin: 0px 0px 15px;"><span style="background-color: rgba(255, 255, 255, 0);">What is your evaluation of <a href="x-apple-data-detectors://7" dir="ltr" x-apple-data-detectors="true" x-apple-data-detectors-type="misc" x-apple-data-detectors-result="7" style="-webkit-text-decoration-color: rgba(0, 0, 0, 0.258824);">the proposal</a>?</span></p><p style="-webkit-print-color-adjust: exact; margin: 0px 0px 15px;"><span style="background-color: rgba(255, 255, 255, 0);">-1</span></p><p style="-webkit-print-color-adjust: exact; margin: 0px 0px 15px;"><span style="background-color: rgba(255, 255, 255, 0);">The proposal puts all the emphasis on the programmer. It is better for the compiler to decide if something is to be inclined both across modules and within modules. </span></p><p style="-webkit-print-color-adjust: exact; margin: 0px 0px 15px;"><span style="background-color: rgba(255, 255, 255, 0);">If something is made public then it should be fixed for a given major version number. No need for extra annotation. </span></p><p style="-webkit-print-color-adjust: exact; margin: 0px 0px 15px;"><span style="background-color: rgba(255, 255, 255, 0);">A module system that allows versioning is a better solution. </span></p></li><li style="-webkit-print-color-adjust: exact; margin: 0px;"><p style="-webkit-print-color-adjust: exact; margin: 0px 0px 15px;"><span style="background-color: rgba(255, 255, 255, 0);">Is the problem being addressed significant enough to warrant a change to Swift?</span></p><p style="-webkit-print-color-adjust: exact; margin: 0px 0px 15px;"><span style="background-color: rgba(255, 255, 255, 0);">Yes significant but wrong solution </span></p></li><li style="-webkit-print-color-adjust: exact; margin: 0px;"><p style="-webkit-print-color-adjust: exact; margin: 0px 0px 15px;"><span style="background-color: rgba(255, 255, 255, 0);">Does this proposal fit well with the feel and direction of Swift?</span></p><p style="-webkit-print-color-adjust: exact; margin: 0px 0px 15px;"><span style="background-color: rgba(255, 255, 255, 0);">No, cluttering up declarations is completely against the clarity of Swift. For example who other than people on this group will understand @inline(never) @inlinable. </span></p></li><li style="-webkit-print-color-adjust: exact; margin: 0px;"><p style="-webkit-print-color-adjust: exact; margin: 0px 0px 15px;"><span style="background-color: rgba(255, 255, 255, 0);">If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?</span></p><p style="-webkit-print-color-adjust: exact; margin: 0px 0px 15px;"><span style="background-color: rgba(255, 255, 255, 0);">Yes C and C++ and found the equivalent of these annotations problematic. In Java they eliminated all this and let the compiler do the work. In practice this works much better. </span></p><p style="-webkit-print-color-adjust: exact; margin: 0px 0px 15px;"><span style="background-color: rgba(255, 255, 255, 0);">Perhaps the compiler should publish the SIL or LLVM for all public functions. Analogous to Java’s class files. This sort of system works really will, much better than C and C++. </span></p></li><li style="-webkit-print-color-adjust: exact; margin: 0px;"><p style="-webkit-print-color-adjust: exact; margin: 0px 0px 15px;"><span style="background-color: rgba(255, 255, 255, 0);">How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</span></p><div>Followed the discussions and read the proposal. The proposal doesn’t seem to encompass all the discussions. It would be nice if the proposal had a much more extensive summary of alternatives suggested. </div></li></ul><div id="AppleMailSignature">-- Howard. </div><div><br>On 20 Dec 2017, at 7:19 pm, Ted Kremenek via swift-evolution <<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a>> wrote:<br><br></div><blockquote type="cite"><div><p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);"><span>The proposal</span> is available here:</p>
<blockquote style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;">
<p style="-webkit-print-color-adjust: exact; margin: 0px;"><span><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0193-cross-module-inlining-and-specialization.md">https://github.com/apple/swift-evolution/blob/master/proposals/0193-cross-module-inlining-and-specialization.md</a></span></p>
</blockquote>
<p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);">Reviews are an important part of the Swift evolution process. All review feedback should be sent to the swift-evolution mailing list at:</p>
<blockquote style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;">
<p style="-webkit-print-color-adjust: exact; margin: 0px;"><span><a href="https://lists.swift.org/mailman/listinfo/swift-evolution">https://lists.swift.org/mailman/listinfo/swift-evolution</a></span></p>
</blockquote>
<p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);">or, if you would like to keep your feedback private, directly to the review manager. </p>
<p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);">When replying, please try to keep <span>the proposal</span> link at the top of the message:</p>
<blockquote style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;">
<p style="-webkit-print-color-adjust: exact; margin: 0px;">Proposal link: <span><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0193-cross-module-inlining-and-specialization.md">https://github.com/apple/swift-evolution/blob/master/proposals/0193-cross-module-inlining-and-specialization.md</a></span><br style="-webkit-print-color-adjust: exact;">
...<br style="-webkit-print-color-adjust: exact;">
Reply text<br style="-webkit-print-color-adjust: exact;">
...<br style="-webkit-print-color-adjust: exact;">
Other replies</p>
</blockquote>
<h3 id="toc_0" style="-webkit-print-color-adjust: exact; margin: 20px 0px 10px; padding: 0px; -webkit-font-smoothing: antialiased; cursor: text; position: relative; font-size: 18px; font-family: Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);">What goes into a review of a proposal?</h3>
<p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);">The goal of the review process is to improve <span>the proposal</span> under review through constructive criticism and, eventually, determine the direction of Swift. </p>
<p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);">When reviewing a proposal, here are some questions to consider:</p>
<ul style="-webkit-print-color-adjust: exact; margin: 15px 0px; padding-left: 30px; font-family: Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);">
<li style="-webkit-print-color-adjust: exact; margin: 0px;">
<p style="-webkit-print-color-adjust: exact; margin: 0px 0px 15px;">What is your evaluation of <span>the proposal</span>?</p>
</li>
<li style="-webkit-print-color-adjust: exact; margin: 0px;">
<p style="-webkit-print-color-adjust: exact; margin: 0px 0px 15px;">Is the problem being addressed significant enough to warrant a change to Swift?</p>
</li>
<li style="-webkit-print-color-adjust: exact; margin: 0px;">
<p style="-webkit-print-color-adjust: exact; margin: 0px 0px 15px;">Does this proposal fit well with the feel and direction of Swift?</p>
</li>
<li style="-webkit-print-color-adjust: exact; margin: 0px;">
<p style="-webkit-print-color-adjust: exact; margin: 0px 0px 15px;">If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?</p>
</li>
<li style="-webkit-print-color-adjust: exact; margin: 0px;">
<p style="-webkit-print-color-adjust: exact; margin: 0px 0px 15px;">How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</p>
</li>
</ul>
<p style="-webkit-print-color-adjust: exact; margin-top: 15px; margin-right: 0px; margin-left: 0px; font-family: Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255); margin-bottom: 0px !important;"></p></div></blockquote></body></html>