<div dir="ltr"><p style="font-size:12.8px;margin:15px 0px;font-family:Helvetica,arial,sans-serif"><span style="font-size:12.8px">The proposal is available here:</span><br></p><blockquote style="font-size:12.8px;margin:15px 0px;border-left:4px solid rgb(221,221,221);padding:0px 15px;color:rgb(119,119,119);font-family:Helvetica,arial,sans-serif"><div style="margin:0px"><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0189-restrict-cross-module-struct-initializers.md" target="_blank">https://github.com/apple/<wbr>swift-evolution/blob/master/<wbr>proposals/0189-restrict-cross-<wbr>module-struct-initializers.md</a></div></blockquote><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature"><ul style="font-size:12.8px;margin:15px 0px;padding-left:30px;font-family:Helvetica,arial,sans-serif"><li style="margin:0px"><p style="margin:0px 0px 15px">What is your evaluation of the proposal?</p></li></ul><font face="Helvetica, arial, sans-serif"><span style="font-size:12.8px">+1, more an oversight in the original design rather than a change. Funny how this problem was caught for classes and not structs.<br></span></font><ul style="font-size:12.8px;margin:15px 0px;padding-left:30px;font-family:Helvetica,arial,sans-serif"><li style="margin:0px"><p style="margin:0px 0px 15px">Is the problem being addressed significant enough to warrant a change to Swift?</p></li></ul><font face="Helvetica, arial, sans-serif"><span style="font-size:12.8px">Yes, focus is on getting rid of inconsistencies and problems.<br></span></font><ul style="font-size:12.8px;margin:15px 0px;padding-left:30px;font-family:Helvetica,arial,sans-serif"><li style="margin:0px"><p style="margin:0px 0px 15px">Does this proposal fit well with the feel and direction of Swift?</p></li></ul><font face="Helvetica, arial, sans-serif"><span style="font-size:12.8px">Yes, Swift is meant to be consistent.<br></span></font><ul style="font-size:12.8px;margin:15px 0px;padding-left:30px;font-family:Helvetica,arial,sans-serif"><li style="margin:0px"><p style="margin:0px 0px 15px">If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?</p></li></ul><font face="Helvetica, arial, sans-serif"><span style="font-size:12.8px">No<br></span></font><ul style="font-size:12.8px;margin:15px 0px;padding-left:30px;font-family:Helvetica,arial,sans-serif"><li style="margin:0px"><p style="margin:0px 0px 15px">How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</p></li></ul><font face="Helvetica, arial, sans-serif"><span style="font-size:12.8px">Glance</span></font></div><div class="gmail_signature"><br></div><div class="gmail_signature"> -- Howard.<br></div></div>
<br><div class="gmail_quote">On 15 November 2017 at 08:24, Jordan Rose via swift-evolution <span dir="ltr"><<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div>Hi, David. This only affects <i>cross-module</i> use cases, which means that the automatically synthesized initializer doesn’t come into play (because it’s not public). Is the clarification you’re looking for something like “a 'source-breaking change’ is something that can cause previously compiling code in another module to result in compile-time errors”?</div><div><br></div><div>Thanks for pointing out the potential for confusion here!</div><div>Jordan</div><div><div class="gmail-h5"><br><div><br><blockquote type="cite"><div>On Nov 14, 2017, at 12:55, David Hart <<a href="mailto:david@hartbit.com" target="_blank">david@hartbit.com</a>> wrote:</div><br class="gmail-m_3546311688421506423Apple-interchange-newline"><div><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline">I was initially quite confused about the proposal's first sentence: "Adding a property to a public struct in Swift ought to not be a source-breaking change.” Because I nearly always rely (like many developers) on struct automatic initializers, adding a property is pretty much always a source-breaking if I don’t write an explicit initializer with the same signature as the old automatic. Can something be done to clarify the proposal in that regard or is it too late?</span><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br></div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">David.<br><div><div><br><blockquote type="cite"><div>On 14 Nov 2017, at 20:31, Ted Kremenek via swift-evolution <<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>> wrote:</div><br class="gmail-m_3546311688421506423Apple-interchange-newline"><div><div style="word-wrap:break-word"><p style="margin:0px 0px 15px;font-family:Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">The review of "SE-0189: Restrict Cross-module Struct Initializers" begins now and runs through <strong>November 21, 2017</strong>.</p><p style="margin:15px 0px;font-family:Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">The proposal is available here:</p><blockquote style="margin:15px 0px;border-left:4px solid rgb(221,221,221);padding:0px 15px;color:rgb(119,119,119);font-family:Helvetica,arial,sans-serif;background-color:rgb(255,255,255)"><div style="margin:0px"><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0189-restrict-cross-module-struct-initializers.md" target="_blank">https://github.com/apple/<wbr>swift-evolution/blob/master/<wbr>proposals/0189-restrict-cross-<wbr>module-struct-initializers.md</a></div></blockquote><p style="margin:15px 0px;font-family:Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">Reviews are an important part of the Swift evolution process. All review feedback should be sent to the swift-evolution mailing list at:</p><blockquote style="margin:15px 0px;border-left:4px solid rgb(221,221,221);padding:0px 15px;color:rgb(119,119,119);font-family:Helvetica,arial,sans-serif;background-color:rgb(255,255,255)"><div style="margin:0px"><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-<wbr>evolution</a></div></blockquote><p style="margin:15px 0px;font-family:Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">or, if you would like to keep your feedback private, directly to the review manager. </p><p style="margin:15px 0px;font-family:Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">When replying, please try to keep the proposal link at the top of the message:</p><blockquote style="margin:15px 0px;border-left:4px solid rgb(221,221,221);padding:0px 15px;color:rgb(119,119,119);font-family:Helvetica,arial,sans-serif;background-color:rgb(255,255,255)"><div style="margin:0px">Proposal link:<span class="gmail-m_3546311688421506423Apple-converted-space"> </span><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0189-restrict-cross-module-struct-initializers.md" target="_blank">https://github.com/<wbr>apple/swift-evolution/blob/<wbr>master/proposals/0189-<wbr>restrict-cross-module-struct-<wbr>initializers.md</a><br>...<br>Reply text<br>...<br>Other replies</div></blockquote><h3 id="gmail-m_3546311688421506423toc_0" style="margin:20px 0px 10px;padding:0px;font-size:18px;font-family:Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">What goes into a review of a proposal?</h3><p style="margin:15px 0px;font-family:Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. </p><p style="margin:15px 0px;font-family:Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">When reviewing a proposal, here are some questions to consider:</p><ul style="margin:15px 0px;padding-left:30px;font-family:Helvetica,arial,sans-serif;background-color:rgb(255,255,255)"><li style="margin:0px"><p style="margin:0px 0px 15px">What is your evaluation of the proposal?</p></li><li style="margin:0px"><p style="margin:0px 0px 15px">Is the problem being addressed significant enough to warrant a change to Swift?</p></li><li style="margin:0px"><p style="margin:0px 0px 15px">Does this proposal fit well with the feel and direction of Swift?</p></li><li style="margin:0px"><p style="margin:0px 0px 15px">If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?</p></li><li style="margin:0px"><p style="margin:0px 0px 15px">How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</p></li></ul><p style="margin:15px 0px 0px;font-family:Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">Thanks,<br>Ted Kremenek<br>Review Manager</p></div>______________________________<wbr>_________________<br>swift-evolution mailing list<br><a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a><br><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-<wbr>evolution</a></div></blockquote></div></div></div></div></blockquote></div><br></div></div></div><br>______________________________<wbr>_________________<br>
swift-evolution mailing list<br>
<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-<wbr>evolution</a><br>
<br></blockquote></div><br></div></div>