<div dir="ltr"><p style="color:rgb(106,115,125);font-family:-apple-system,BlinkMacSystemFont,"Segoe UI",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol";font-size:16px;box-sizing:border-box;margin-top:0px;margin-bottom:16px">Proposal link:</p><div style="font-size:12.8px"><span class="gmail-m_7989032545547359305Apple-tab-span" style="white-space:pre-wrap"> </span><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0188-stdlib-index-types-hashable.md" target="_blank">https://github.com/apple/<wbr>swift-evolution/blob/master/<wbr>proposals/0188-stdlib-index-<wbr>types-hashable.md</a><div id="gmail-matdtBrBUT" class="gmail-donut-container"><div class="gmail-donut gmail-donut_green"></div></div></div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px"><div style="font-size:12.8px"><span class="gmail-m_7989032545547359305Apple-tab-span" style="font-size:12.8px;white-space:pre-wrap"> </span>• What is your evaluation of the proposal?<br></div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">+1 but would like it to further and require all index types to be Hashable.</div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px"><span class="gmail-m_7989032545547359305Apple-tab-span" style="white-space:pre-wrap"> </span>• Is the problem being addressed significant enough to warrant a change to Swift?<br></div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">It has been a problem for me in the past, however just requiring the standard library ones to be hashable would solve the problem of third party libraries, therefore suggest all hashable.</div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px"><span class="gmail-m_7989032545547359305Apple-tab-span" style="white-space:pre-wrap"> </span>• Does this proposal fit well with the feel and direction of Swift?<br></div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">Yes, this is the sort of thing that needs finalising before ABI stability else we will be stuck with a problem.</div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px"><span class="gmail-m_7989032545547359305Apple-tab-span" style="white-space:pre-wrap"> </span>• If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br></div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">Yes, Java, Scala, etc. Most languages have a hashable index so you can have a set on indices etc.</div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px"><span class="gmail-m_7989032545547359305Apple-tab-span" style="white-space:pre-wrap"> </span>• How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">Have read the review and have also implemented my own collections, which used hashable indices.</div></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"> -- Howard.<br></div></div>
<br><div class="gmail_quote">On 9 November 2017 at 12:55, Ben Cohen via swift-evolution <span dir="ltr"><<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space">Hello, Swift community!<div><br></div><div>The review of “SE-0188: Make stdlib index types Hashable” begins now and runs through November 14th, 2017. The proposal is available here:</div><div><br></div><div><span class="m_7989032545547359305Apple-tab-span" style="white-space:pre-wrap"> </span><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0188-stdlib-index-types-hashable.md" target="_blank">https://github.com/apple/<wbr>swift-evolution/blob/master/<wbr>proposals/0188-stdlib-index-<wbr>types-hashable.md</a></div><div><br></div><div><div>Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at</div><div><br></div><blockquote style="margin:0px 0px 0px 40px;border:none;padding:0px"><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-<wbr>evolution</a></blockquote><br>or, if you would like to keep your feedback private, directly to me as the review manager. When replying, please try to keep the proposal link at the top of the message:<br><br></div><div><p style="background-color:rgb(255,255,255);color:rgb(106,115,125);font-family:-apple-system,BlinkMacSystemFont,"Segoe UI",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol";font-size:16px;box-sizing:border-box;margin-top:0px;margin-bottom:16px">Proposal link:</p><div style="background-color:rgb(255,255,255)"><span class="m_7989032545547359305Apple-tab-span" style="white-space:pre-wrap"> </span><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0188-stdlib-index-types-hashable.md" target="_blank">https://github.com/apple/<wbr>swift-evolution/blob/master/<wbr>proposals/0188-stdlib-index-<wbr>types-hashable.md</a></div><div style="background-color:rgb(255,255,255)"><br></div><div style="background-color:rgb(255,255,255)"><blockquote style="box-sizing:border-box;margin:0px 0px 16px;padding:0px 1em;color:rgb(106,115,125);border-left-width:0.25em;border-left-style:solid;border-left-color:rgb(223,226,229);font-family:-apple-system,BlinkMacSystemFont,"Segoe UI",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol";font-size:16px"><div style="box-sizing:border-box;margin-top:0px;margin-bottom:0px">Reply text</div></blockquote><blockquote style="box-sizing:border-box;margin:0px 0px 16px;padding:0px 1em;color:rgb(106,115,125);border-left-width:0.25em;border-left-style:solid;border-left-color:rgb(223,226,229);font-family:-apple-system,BlinkMacSystemFont,"Segoe UI",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol";font-size:16px"><blockquote style="box-sizing:border-box;margin:0px;padding:0px 1em;border-left-width:0.25em;border-left-style:solid;border-left-color:rgb(223,226,229)"><div style="box-sizing:border-box;margin-top:0px;margin-bottom:0px">Other replies</div></blockquote></blockquote></div></div><div><b>What goes into a review?</b><br><br>The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift.<div><br></div><div>When writing your review, here are some questions you might want to answer in your review:<br><br><div><span class="m_7989032545547359305Apple-tab-span" style="white-space:pre-wrap"> </span>• What is your evaluation of the proposal?<br></div><div><span class="m_7989032545547359305Apple-tab-span" style="white-space:pre-wrap"> </span>• Is the problem being addressed significant enough to warrant a change to Swift?<br></div><div><span class="m_7989032545547359305Apple-tab-span" style="white-space:pre-wrap"> </span>• Does this proposal fit well with the feel and direction of Swift?<br></div><div><span class="m_7989032545547359305Apple-tab-span" style="white-space:pre-wrap"> </span>• If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br></div><div><span class="m_7989032545547359305Apple-tab-span" style="white-space:pre-wrap"> </span>• How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br></div><div><br></div>More information about the Swift evolution process is available at:<div><br></div><blockquote style="margin:0px 0px 0px 40px;border:none;padding:0px"><div><a href="https://github.com/apple/swift-evolution/blob/master/process.md" target="_blank">https://github.com/apple/<wbr>swift-evolution/blob/master/<wbr>process.md</a></div></blockquote><div><br>As always, thank you for contributing to the evolution of Swift.</div><div><br></div><div>Ben Cohen</div><div>Review Manager</div><div><br></div><div><br></div></div></div><div><br></div></div><br>______________________________<wbr>_________________<br>
swift-evolution mailing list<br>
<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-<wbr>evolution</a><br>
<br></blockquote></div><br></div>