<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Thanks for continuing to push this forward, Alejandro! I’m excited about the potential of having access to these APIs as part of the standard library. Here are a few comments on some different parts of the proposal:<div class=""><br class=""></div><div class="">1) For your <font face="Menlo" class="">RandomGenerator</font> protocol, I’m not totally clear on the semantics of the <font face="Menlo" class="">next(_:)</font> and <font face="Menlo" class="">next(_:upperBound:)</font> methods. Do they both have zero as their lower bound, for example? I’m not sure it makes sense to have signed integers generated directly by an RNG—perhaps <font face="Menlo" class="">T: FixedWidthInteger & UnsignedInteger</font> would be a more useful constraint. (Does it even need to be generic? What if RNGs just generate <font face="Menlo" class="">UInt32</font>s?)</div><div class=""><br class=""></div><div class="">2) Can you say more about the purpose of the <font face="Menlo" class="">Randomizable</font> protocol? How would we use that protocol in useful ways that we wouldn’t get from being able to select random values from ranges (half-open and closed) of <font face="Menlo" class="">FixedWidthInteger</font> / <font face="Menlo" class="">BinaryFloatingPoint</font>? My experience has been that a full-width random value is rarely what a user needs.</div><div class=""><br class=""></div><div class="">3) I agree with Xiaodi that <font face="Menlo" class="">Random</font> should probably be a struct with a single shared instance, but I don’t think it should be internal. Hiding that shared RNG would make it hard for non-stdlib additions to have the same usage, as they would need to have completely separate implementations for the “default” and custom RNG versions.</div><div class=""><br class=""></div><div class="">4) I would also still suggest that the simplest version of <font face="Menlo" class="">random</font> (that you use to get a value from a range or an element from a collection) should be a function, not a property. Collection properties like <font face="Menlo" class="">first</font>, <font face="Menlo" class="">last</font>, and <font face="Menlo" class="">count</font> all represent facts that already exist about a collection, and don’t change unless the collection itself changes. Choosing a random element, on the other hand, is clearly going to be freshly performed on each call. In addition, with the notable exception of <font face="Menlo" class="">count</font>, we try to ensure O(1) performance for properties, while <font face="Menlo" class="">random</font> will be O(n) except in random-access collections. Finally, if it is a method, we can unify the two versions by providing a single method with the shared RNG as the default parameter.</div><div class=""><br class=""></div><div class="">5) To match the <font face="Menlo" class="">sorted()</font> method, <font face="Menlo" class="">shuffled()</font> should be on <font face="Menlo" class="">Sequence</font> instead of <font face="Menlo" class="">Collection</font>. I don’t think either <font face="Menlo" class="">shuffled()</font> or <font face="Menlo" class="">shuffle()</font> needs to be a protocol requirement, since there isn’t really any kind of customization necessary for different kinds of collections. Like the sorting algorithms, both could be regular extension methods.<div class=""><div><br class=""></div><div>6) I don’t know whether or not a consensus has formed around the correct spelling of the APIs for generating random values. From the proposal it looks like the preferred ways of getting a random value in a range would be to use the random property (or method) on a range or closed range:</div><div><br class=""></div><div><font face="Menlo" class=""> (0..<10).random // 7</font></div><div><font face="Menlo" class=""> (0.0 ... 5.0).random // 4.112312</font></div><div><br class=""></div><div>If that’s the goal, and we don’t want those values to be optional, we’ll need an implementation of random for floating-point ranges and an overload for fixed-width integer ranges. That said, I don’t think that style is as discoverable as having static methods or initializers available on the different types:</div><div><br class=""></div><div><span style="font-family: Menlo;" class=""> Int.random(in: 0..<10)</span></div><div><span style="font-family: Menlo;" class=""> Double.random(in: 0.0 ... 5.0)</span></div><div><font face="Menlo" class=""> // or maybe</font></div><div><font face="Menlo" class=""> Int(randomIn: 0..<10)</font></div><div><font face="Menlo" class=""> Double(randomIn: 0.0 ... 5.0)</font></div><div><br class=""></div><div>(My only quibble with the initializer approach is that <font face="Menlo" class="">Bool</font> would be awkward.)</div><div><br class=""></div><div>In addition, this alternative approach could make creating random values more consistent with types that don’t work well in ranges:</div><div><br class=""></div><div><div><span style="font-family: Menlo;" class=""> Data.random(bytes: 128)</span></div><div><span style="font-family: Menlo;" class=""> Color.random(r: 0...0, g: 0...1, b: 0...1, a: 1...1)</span></div><div class=""><br class=""></div><div class=""><span style="font-family: Menlo;" class="">————</span></div><div class=""><span style="font-family: Menlo;" class=""><br class=""></span></div></div><div>Thanks again!</div><div>Nate</div><div><br class=""><blockquote type="cite" class=""><div class="">On Nov 5, 2017, at 6:33 PM, Alejandro Alonso via swift-evolution <<a href="mailto:swift-evolution@swift.org" class="">swift-evolution@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" class="">
<title class=""></title>
<div class="">
<div name="messageBodySection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;" class="">
<a href="https://github.com/apple/swift-evolution/pull/760" class="">https://github.com/apple/swift-evolution/pull/760</a> is the current API and proposed solution.</div>
<div name="messageSignatureSection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;" class="">
<br class="">
- Alejandro</div>
<div name="messageReplySection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;" class="">
<br class="">
On Nov 5, 2017, 6:18 PM -0600, Xiaodi Wu <<a href="mailto:xiaodi.wu@gmail.com" class="">xiaodi.wu@gmail.com</a>>, wrote:<br class="">
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;" class="">
<div dir="ltr" class="">
<div class="">My comments are directed to the "more up-to-date" document that you just linked to in your reply to Jon. Is that one outdated? If so, can you send a link to the updated proposal and implementation for which you're soliciting feedback?</div>
<br class="">
<div class="gmail_extra"><br class="">
<div class="gmail_quote">On Sun, Nov 5, 2017 at 6:12 PM, Alejandro Alonso <span dir="ltr" class="">
<<a href="mailto:aalonso128@outlook.com" target="_blank" class="">aalonso128@outlook.com</a>></span> wrote:<br class="">
<blockquote class="gmail_quote" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #e67e22;">
<div class="">
<div name="messageBodySection" style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif" class="">
The proposal and implementation have the current updated API. The link I sent Jon was the one I brought up a few weeks ago which is outdated now. The proposal answers all of your questions. As for `.random` being a function, some would argue that it behaves
in the same way as `.first` and `.last` which are properties.</div>
<div class="HOEnZb"><font color="#888888" class=""></font>
<div name="messageSignatureSection" style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif" class="">
<font color="#888888" class=""><br class="">
- Alejandro</font></div>
</div>
<div class="">
<div class="h5">
<div name="messageReplySection" style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif" class="">
<br class="">
On Nov 5, 2017, 6:07 PM -0600, Xiaodi Wu <<a href="mailto:xiaodi.wu@gmail.com" target="_blank" class="">xiaodi.wu@gmail.com</a>>, wrote:<br class="">
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #3498db;" class="">
<div dir="ltr" class="">A few quick thoughts:
<div class=""><br class="">
</div>
<div class="">I know that there's been some discussion that `(1...10).random` is the best spelling, but I'd like to push back on that suggestion. When I want a random number, I tend to think of the type I want first ("I want a random integer") and then a range ("I want
a random integer between a and b"), not the other way around. My intuition is that `Int.random(in:)` will be more discoverable, both on that basis and because it is more similar to other languages' syntax (`Math.random` in JavaScript and `randint` in NumPy,
for example). It also has the advantage that the type is explicit, which I think is particularly useful in this case because the value itself is, well, random.</div>
<div class=""><br class="">
</div>
<div class="">I would also argue that, `random` is most appropriately a method and not a property; there's no hard and fast rule for this, but the fact that the result is stochastic suggests (to me) that it's not a "property" of the range (or, for that matter, of the
type).</div>
<div class=""><br class="">
</div>
<div class="">
<div class="">I would reiterate here my qualms about `Source` being the term used for a generator. These types are not a _source_ of entropy but rather a _consumer_ of entropy.</div>
</div>
<div class=""><br class="">
</div>
<div class="">`UnsafeRandomSource` needs to be renamed; "unsafe" has a specific meaning in Swift--that is, memory safety, and this is not it. Moreover, it's questionable whether this protocol is useful in any sense. What useful generic algorithms can one write with
such a protocol?</div>
<div class=""><br class="">
</div>
<div class="">`XoroshiroRandom` cannot be seeded by any `Numeric` value; depending on the specific algorithm it needs a seed of a specific bit width. If you default the shared instance to being seeded with an `Int` then you will have to have distinct implementations
for 32-bit and 64-bit platforms. This is unadvisable. On that note, your `UnsafeRandomSource` needs to have an associated type and not a generic `<T : Numeric>` for the seed.<br class="">
</div>
<div class=""><br class="">
</div>
<div class="">The default random number generator should be cryptographically secure; however, it's not clear to me that it should be device random.</div>
<div class=""><br class="">
</div>
<div class="">I agree with others that alternative random number generators other than the default RNG (and, if not default, possibly also the device RNG) should be accommodated by the protocol hierarchy but not necessarily supplied in the stdlib.</div>
<div class=""><br class="">
</div>
<div class="">The term `Randomizable` means something specific which is not how it's used in your proposed protocol. </div>
<div class=""><br class="">
</div>
<div class="">There's still the open question, not answered, about how requesting an instance of the hardware RNG behaves when there's insufficient or no entropy. Does it return nil, throw, trap, or wait? The proposed API does not clarify this point, although based
on the method signature it cannot return nil or throw. Trapping might be acceptable but I'd be interested to hear your take as to why it is preferable.</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div class="gmail_extra">
<div class="gmail_quote">On Sun, Nov 5, 2017 at 4:43 PM, Alejandro Alonso via swift-evolution
<span dir="ltr" class=""><<a href="mailto:swift-evolution@swift.org" target="_blank" class="">swift-evolution@swift.org</a>></span> wrote:<br class="">
<blockquote class="gmail_quote" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #d35400;">
<div class="">
<div name="messageBodySection" style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif" class="">
For the proof of concept, I had accidentally deleted that one. I have a more up to date one which was discussed a few weeks later. <a href="https://gist.github.com/Azoy/15f0518df38df9b722d4cb17bafea4c1" target="_blank" class="">https://gist.github.com<wbr class="">/Azoy/15f0518df38df9b722d4cb17<wbr class="">bafea4c1</a></div>
<div name="messageSignatureSection" style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif" class="">
<br class="">
- Alejandro</div>
<div class="">
<div class="m_1947579187318224822gmail-h5">
<div name="messageReplySection" style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif" class="">
<br class="">
On Nov 5, 2017, 4:37 PM -0600, Jonathan Hull <<a href="mailto:jhull@gbis.com" target="_blank" class="">jhull@gbis.com</a>>, wrote:<br class="">
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #34495e;" class="">
Is there a link to the writeup? The one in the quote 404s.
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class="">Jon</div>
<div class=""><br class="">
<div class="">
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #2ecc71;" class="">
<div class="">On Nov 5, 2017, at 2:10 PM, Alejandro Alonso via swift-evolution <<a href="mailto:swift-evolution@swift.org" target="_blank" class="">swift-evolution@swift.org</a>> wrote:</div>
<br class="m_1947579187318224822gmail-m_3739135728595962658Apple-interchange-newline">
<div class="">
<div class="">
<div name="messageBodySection" style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif" class="">
Hello once again Swift evolution community. I have taken the time to write up the proposal for this thread, and have provided an implementation for it as well. I hope to once again get good feedback on the overall proposal.</div>
<div name="messageSignatureSection" style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif" class="">
<br class="">
- Alejandro</div>
<div name="messageReplySection" style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif" class="">
<br class="">
On Sep 8, 2017, 11:52 AM -0500, Alejandro Alonso via swift-evolution <<a href="mailto:swift-evolution@swift.org" target="_blank" class="">swift-evolution@swift.org</a>>, wrote:<br class="">
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #9b59b6;" class="">
<div name="messageBodySection" style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif" class="">
Hello swift evolution, I would like to propose a unified approach to `random()` in Swift. I have a simple implementation here <a href="https://gist.github.com/Azoy/5d294148c8b97d20b96ee64f434bb4f5" target="_blank" class="">https://gist.github.com/A<wbr class="">zoy/5d294148c8b97d20b96ee64f43<wbr class="">4bb4f5</a>.
This implementation is a simple wrapper over existing random functions so existing code bases will not be affected. Also, this approach introduces a new random feature for Linux users that give them access to upper bounds, as well as a lower bound for both
Glibc and Darwin users. This change would be implemented within Foundation.
<div class=""><br class="">
</div>
<div class="">I believe this simple change could have a very positive impact on new developers learning Swift and experienced developers being able to write single random declarations.</div>
<div class=""><br class="">
</div>
<div class="">I’d like to hear about your ideas on this proposal, or any implementation changes if need be.</div>
<div class=""><br class="">
</div>
<div class="">- Alejando</div>
</div>
<div name="messageReplySection" style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif" class="">
<br class="">
<div class=""></div>
</div>
</blockquote>
</div>
</div>
______________________________<wbr class="">_________________<br class="">
swift-evolution mailing list<br class="">
<a href="mailto:swift-evolution@swift.org" target="_blank" class="">swift-evolution@swift.org</a><br class="">
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" target="_blank" class="">https://lists.swift.org/mailma<wbr class="">n/listinfo/swift-evolution</a><br class="">
</div>
</blockquote>
</div>
<br class="">
</div>
</blockquote>
</div>
</div>
</div>
</div>
<br class="">
______________________________<wbr class="">_________________<br class="">
swift-evolution mailing list<br class="">
<a href="mailto:swift-evolution@swift.org" target="_blank" class="">swift-evolution@swift.org</a><br class="">
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank" class="">https://lists.swift.org/mailma<wbr class="">n/listinfo/swift-evolution</a><br class="">
<br class="">
</blockquote>
</div>
<br class="">
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</blockquote>
</div>
</div>
_______________________________________________<br class="">swift-evolution mailing list<br class=""><a href="mailto:swift-evolution@swift.org" class="">swift-evolution@swift.org</a><br class="">https://lists.swift.org/mailman/listinfo/swift-evolution<br class=""></div></blockquote></div><br class=""></div></div></body></html>