<div dir="ltr">On Tue, Jul 11, 2017 at 12:54 PM, Daniel Dunbar via swift-evolution <span dir="ltr"><<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div style="word-wrap:break-word"><div>Hello Swift community,</div><div><br></div><div>The review of <b>SE-0181: Package Manager C/C++ Language Standard Support</b> begins now and runs through <b>July 14th, 2017</b>.</div><div><br></div><div>The proposal is available here:</div><div><br></div><div> <a href="https://github.com/apple/swift-evolution/blob/master/proposals/0181-package-manager-cpp-language-version.md" target="_blank">https://github.com/apple/<wbr>swift-evolution/blob/master/<wbr>proposals/0181-package-<wbr>manager-cpp-language-version.<wbr>md</a></div><div><br></div><div>Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-build-dev and swift-evolution mailing lists at</div><div><br></div><div><div> <a href="https://lists.swift.org/mailman/listinfo/swift-build-dev" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-build-<wbr>dev</a></div></div><div><div> <a href="https://lists.swift.org/mailman/listinfo/swift-evolution" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-<wbr>evolution</a></div></div><div><br></div><div><span style="font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:</span></div><div><blockquote style="margin:15px 0px;border-left-width:4px;border-left-style:solid;border-left-color:rgb(221,221,221);padding:0px 15px;color:rgb(119,119,119);font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)"><h3 id="m_-1356155063793174641toc_0" style="margin:0px 0px 10px;padding:0px;font-size:18px">Proposal link:</h3><blockquote style="margin:15px 0px 0px;border-left-width:4px;border-left-style:solid;border-left-color:rgb(221,221,221);padding:0px 15px"><p style="margin:0px 0px 15px"><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0181-package-manager-cpp-language-version.md" target="_blank">https://github.com/apple/<wbr>swift-evolution/blob/master/<wbr>proposals/0181-package-<wbr>manager-cpp-language-version.<wbr>md</a></p><h3 id="m_-1356155063793174641toc_1" style="margin:20px 0px 10px;padding:0px;font-size:18px">Reply text</h3><p style="margin:15px 0px 0px">Other replies</p></blockquote></blockquote><h3 id="m_-1356155063793174641toc_2" style="margin:20px 0px 10px;padding:0px;font-size:18px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">What goes into a review?</h3><p style="margin:15px 0px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:</p><ul style="margin:15px 0px;padding-left:30px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)"><li style="margin:0px">What is your evaluation of the proposal?</li></ul></div></div></div></blockquote><div><br></div><div>As a temporary measure, acceptable; very much looking forward to true build settings. I would tend to agree with original proposal authors that, since this design is intended to be transitional, having these enum cases closely mirror the underlying options 1:1 is the way to go.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div style="word-wrap:break-word"><div><ul style="margin:15px 0px;padding-left:30px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)"><li style="margin:0px">Is the problem being addressed significant enough to warrant a change to Swift?</li></ul></div></div></div></blockquote><div><br></div><div>Yes.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div style="word-wrap:break-word"><div><ul style="margin:15px 0px;padding-left:30px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)"><li style="margin:0px">Does this proposal fit well with the feel and direction of Swift?</li></ul></div></div></div></blockquote><div><br></div><div>It fits OK, with some nits:</div><div><br></div><div>* Since the corresponding Swift feature is specified by the label `swiftLanguageVersion` and the proposed enum is named `CLanguageStandard`, shouldn't the label be `cLanguageStandard` instead of `cStandard`?</div><div>* Since the underlying option is named "gnu++11", shouldn't the enum case be `gnuxx11` and not `gnucxx11`?</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div style="word-wrap:break-word"><div><ul style="margin:15px 0px;padding-left:30px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)"><li style="margin:0px">If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?</li></ul></div></div></div></blockquote><div><br></div><div>This is the first package manager I've worked with that builds both another language and C/C++.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div style="word-wrap:break-word"><div><ul style="margin:15px 0px;padding-left:30px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)"><li style="margin:0px">How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</li></ul></div></div></div></blockquote><div><br></div><div>Some study, though not necessary as in-depth as it could be.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div style="word-wrap:break-word"><div><p style="margin:15px 0px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">More information about the Swift evolution process is available at:</p><p style="margin:15px 0px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)"><a href="https://github.com/apple/swift-evolution/blob/master/process.md" style="color:rgb(65,131,196)" target="_blank">https://github.com/apple/<wbr>swift-evolution/blob/master/<wbr>process.md</a></p><p style="margin:15px 0px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">Thank you,<br>Daniel Dunbar (Review Manager)</p></div></div></div><br>______________________________<wbr>_________________<br>
swift-evolution mailing list<br>
<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-<wbr>evolution</a><br>
<br></blockquote></div><br></div></div>